Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pressing Enter on an empty prompt leaves its placeholder on the completed line, so earlier prompts can look as though they are still waiting for input. Hide the placeholder during the final redraw, using the same
is_donefilter as other temporary prompt elements. It remains visible while the prompt is active, and submitted text is unchanged.The regression tests inspect the rendered screens for plain and ANSI-formatted placeholders, with both empty and nonempty input. All four pass; the two empty-input cases fail before the change.
On Windows with Python 3.12, the full suite has 151 passing tests, five existing Windows skips and four failures also reproduced against unchanged source: two history tests and two tests requiring a Windows console. Ruff check/format, Typos and strict Mypy checks for all three configured platforms pass. Other operating systems and Python versions were not tested locally.
Fixes #1997.