PHP 8.5 support, setType in SetChannelMetadata, bug fixes#137
Open
jakub-grzesiowski wants to merge 12 commits into
Open
PHP 8.5 support, setType in SetChannelMetadata, bug fixes#137jakub-grzesiowski wants to merge 12 commits into
jakub-grzesiowski wants to merge 12 commits into
Conversation
Because `->meta(['type' => 'some type'])` is deprecated
It does not work the way it may look at first glance because of operator precedence (https://www.php.net/manual/en/language.operators.precedence.php ) `or` is called after the assignment `=` `||` is called before the assignment = It is interpreted as: ``` ($members = !empty($this->setMembers)) or !empty($this->removeMembers); ``` So if: $this->setMembers has 0 elements → empty(...) is true → !empty(...) is false $this->removeMembers has 1 element → !empty(...) is true Then: $members = false;
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
…set-only / remove-only) requests
…into php-prs-129-131
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add setType in SetChannelMetadata
Added setType to SetChannelMetadata because ->meta(['type' => 'some type']) is deprecated
feat: php 8.5 support
Added SDK support for PHP 8.5
fix: logical operator for member and UUID checks
Fixed incorrect check logic for Member and UUID in members management
fix: minor crypto fixes
Fixed minor issues in PaddingTrait::depad(), PubNubCryptoCore::unPadPKCS7(), and CryptoModule::decodeHeader()
Closes #129 #130 #131