Repository navigation
fix: keep mobile header controls within the viewport - #171
Merged
Merged
Conversation
Reflow the header into two compact rows below the small breakpoint, keep user icons and accessible names intact, and bound Add/activity menus to the header. Preserve existing actions, routes, event handlers, and desktop header height. Prove the original 320px overflow with real browser assertions, then cover both themes, normal and long usernames, keyboard access, menus, and 320-1280px geometry. Full local CI, accessibility, both browser suites, Docker security/runtime guards and seven smoke tests passed.
DeusExTaco
marked this pull request as ready for review
October 16, 2026 08:00
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Give the hydration scheduler test a bounded five-second progress watchdog while preserving its exclusion, ordering, real SQLite, and cleanup assertions. Controlled Linux delay probes demonstrate timeout sensitivity; concurrent and missing work still fail. Production timeouts and worker settings are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I reproduced the header overflowing a 320px viewport, then kept its existing actions reachable without changing their routes, labels or handlers.
Narrow test-only CI correction
I also reproduced the scheduler test's one-second progress-watchdog sensitivity under controlled real Linux database latency. Its three progress waits now use a test-local five-second bound; the original real SQLite setup, ordering/concurrency assertions, 50ms exclusion observation and cleanup are unchanged. Controlled first/second/drain delays pass, while concurrent work and dropped scheduling still fail. This does not prove the exact cause or timing of the earlier remote TimeoutError; the available remote log omitted its detailed traceback.
Validation
make ci-full: passed, including 15,824 main tests, 91.67% coverage against the unchanged 90% gate, 26 accessibility tests, 742 passed / 2 skipped per browser, and all 7 Docker smoke tests.Scope and follow-ups
No production Python, JavaScript handlers, dependency versions, migrations, shared fixtures, worker settings or security policy changed. PR #165 remains deferred. The live 8585 instance and recovery worktree were not changed.
Existing broader content clipping is outside this header fix. Manual observations of donation-dialog focus returning to BODY and an invisible loading indicator during a delayed request are retained without attribution or an unrelated repair. This is not a whole-application accessibility certification.
Full exact-head remote checks and final review are required before merge.