Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
prototypes/orthogonal_forests/monte_carlo.py, the--method_id 2branch instantiates the estimator with a misspelled class name:The class is imported at the top of the file as
DishonestOrthoForest:and defined as
class DishonestOrthoForest(BaseOrthoForest)inprototypes/orthogonal_forests/ortho_forest.py.DishoestOrthoForestis never defined anywhere, so running the Monte Carlo script with--method_id 2raisesNameError: name 'DishoestOrthoForest' is not defined.Fix
Correct the single-character typo
DishoestOrthoForest->DishonestOrthoForest. One-line change; no behavior change to the other branches.🤖 Generated with Claude Code