Skip to content

Fix NameError typo DishoestOrthoForest -> DishonestOrthoForest in monte_carlo prototype - #1062

Open
Anai-Guo wants to merge 1 commit into
py-why:mainfrom
Anai-Guo:fix-dishonest-typo
Open

Anai-Guo wants to merge 1 commit into
py-why:mainfrom
Anai-Guo:fix-dishonest-typo

Conversation

@Anai-Guo

Copy link
Copy Markdown

Problem

In prototypes/orthogonal_forests/monte_carlo.py, the --method_id 2 branch instantiates the estimator with a misspelled class name:

elif args.method_id == 2:
    est = DishoestOrthoForest(...)   # missing the "n"

The class is imported at the top of the file as DishonestOrthoForest:

from ortho_forest import OrthoForest, DishonestOrthoForest

and defined as class DishonestOrthoForest(BaseOrthoForest) in prototypes/orthogonal_forests/ortho_forest.py. DishoestOrthoForest is never defined anywhere, so running the Monte Carlo script with --method_id 2 raises NameError: name 'DishoestOrthoForest' is not defined.

Fix

Correct the single-character typo DishoestOrthoForest -> DishonestOrthoForest. One-line change; no behavior change to the other branches.

🤖 Generated with Claude Code

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant