Skip to content

Check future completion before setting result in ThrottledCallable - #355

Merged
tlambert03 merged 1 commit into
pyapp-kit:mainfrom
ccordoba12:patch-1
Oct 7, 2026
Merged

tlambert03 merged 1 commit into
pyapp-kit:mainfrom
ccordoba12:patch-1

Conversation

@ccordoba12

Copy link
Copy Markdown
Contributor

Hey guys, thanks for the great project! We're using some of its utilities and widgets in Spyder and are very pleased with the results.

This fixes a simple InvalidStateError I'm seeing in a feature I'm working on when using the qdebounced decorator.

@codecov

codecov Bot commented Oct 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.90%. Comparing base (a175047) to head (879c08c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #355   +/-   ##
=======================================
  Coverage   84.90%   84.90%           
=======================================
  Files          49       49           
  Lines        3928     3929    +1     
=======================================
+ Hits         3335     3336    +1     
  Misses        593      593           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlambert03 tlambert03 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to see you here @ccordoba12, and thanks for the fix. glad to hear you're finding some of the utils here useful for spyder. will cut a new release with this change within the next day or tweo

@tlambert03
tlambert03 merged commit 6556735 into pyapp-kit:main Oct 7, 2026
28 of 29 checks passed
@ccordoba12
ccordoba12 deleted the patch-1 branch October 7, 2026 20:03
@ccordoba12

Copy link
Copy Markdown
Contributor Author

Thanks @tlambert03!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants