[ref:seggan/feature/elektrikity] ELEKTRIKITY - #971
Conversation
# Conflicts: # src/main/java/io/github/pylonmc/pylon/PylonBlocks.java # src/main/resources/lang/en.yml
…e/elektrikity # Conflicts: # src/main/java/io/github/pylonmc/pylon/PylonFluids.java # src/main/java/io/github/pylonmc/pylon/content/components/FluidHatch.java # src/main/java/io/github/pylonmc/pylon/content/components/FluidInputHatch.java # src/main/java/io/github/pylonmc/pylon/content/components/FluidOutputHatch.java # src/main/java/io/github/pylonmc/pylon/content/machines/diesel/machines/DieselCoreDrill.java # src/main/java/io/github/pylonmc/pylon/content/machines/diesel/machines/PalladiumCondenser.java # src/main/java/io/github/pylonmc/pylon/content/machines/diesel/production/Biorefinery.java # src/main/java/io/github/pylonmc/pylon/content/machines/experience/FluidExperienceBottler.java # src/main/java/io/github/pylonmc/pylon/content/machines/hydraulics/BurnerHydraulicPurifier.java # src/main/java/io/github/pylonmc/pylon/content/machines/hydraulics/ConvectionHydraulicPurifier.java # src/main/java/io/github/pylonmc/pylon/content/machines/hydraulics/HydraulicCoreDrill.java # src/main/java/io/github/pylonmc/pylon/content/machines/hydraulics/LiseletteHydraulicPurifier.java # src/main/java/io/github/pylonmc/pylon/content/machines/smelting/Kiln.java # src/main/resources/lang/en.yml # src/main/resources/recipes/minecraft/crafting_shaped.yml # src/main/resources/recipes/pylon/assembling.yml
This is fine cause |
…e/elektrikity # Conflicts: # src/main/java/io/github/pylonmc/pylon/PylonFluids.java # src/main/resources/lang/en.yml # src/main/resources/recipes/minecraft/crafting_shaped.yml
|
Added displays/animations to every iron block machine except brick molder and pipe bender |
LordIdra
left a comment
LordIdra
left a comment
There was a problem hiding this comment.
Missing fluid keys
Capacitors do not appear to work
| machines_electricity_production: "<yellow>Electricity Production" | ||
| machines_electric_machines: "<yellow>Electric Machines" | ||
| machines_electricity_utilities: "<yellow>Electricity Utilties" |
There was a problem hiding this comment.
How come these are yellow?
There was a problem hiding this comment.
It might be good to display power production as its own item, since it's a bit hidden down at the bottom of the turbine lore?
Also:
There was a problem hiding this comment.
Having the turbine go from 0 to 60 is a bit jarring, and it stutters if it doesn't have enough input. How much bother would it be to make the speed scale? It doesn't have to be complicated, I'm just thinking constant acceleration/deceleration until stopped / at max speed
There was a problem hiding this comment.
'Bus' is the wrong word for this 'hub' maybe?
There was a problem hiding this comment.
What's the use case of this when any number of wires can connect to a node?
I can see a connector being useful but having 6 ports feels strange given the above
There was a problem hiding this comment.
Wires can't go through blocks/bypassing the wire length limit
There was a problem hiding this comment.
As I learnt in Quaptics, updating text display text can be really quite expensive, so I'd suggest maybe we limit the text display to only one side and/or make it toggleable? (Since I can imagine if players build a big capacitor bank they might want to turn this off)
There was a problem hiding this comment.
Would be good to show contents in WAILA too
4 participants
See #987 section "Foundational Pylon PR"