Conversation
Member
|
@nicoddemus i tihnk we need to transfer the groups separately - id was never supposed to be mutated to begin wirth |
itscloud0
force-pushed
the
fix-1386-loadgroup-nodeid
branch
from
September 22, 2026 17:04
f20f703 to
ffa67fe
Compare
itscloud0
marked this pull request as ready for review
September 23, 2026 06:38
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pytest main uses structured node IDs.
--dist=loadgroupstill writes the legacy_nodeidfield, so grouped tests silently lose their group suffix and are distributed independently.Solution
Update the structured ID when it is available, while retaining the legacy path for supported older pytest releases.
Verification
pytest testing/acceptance_test.py::TestGroupScope -q(6 passed)ruff check --select B010 src/xdist/remote.pyruff format --check src/xdist/remote.pygit diff --checkCloses #1386.