Repository navigation
Forget an instance even when its finaliser raises - #327
Merged
Merged
Conversation
Contributor
antonrh
force-pushed
the
fix-release-drops-instance
branch
from
August 30, 2026 12:47
617c884 to
60bf1d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A regression from the release fix earlier this week, found by a second review
pass over it.
release()ran the finaliser before dropping the instance, so a finaliserthat raised left the instance cached with its resource already closed. The
next resolution handed that closed instance out:
The instance is dropped first now, and the same run reads:
The ordering also aborted
reset()halfway, leaving later singletons neitherclosed nor reset, with nothing to say which half had run.
reset()nowreleases them all and raises the first failure afterwards:
Before this week's change
reset()usedpop, which cannot raise, so italways finished. This restores that guarantee without giving up the closing.