Add complete Apache-2.0 license header for Arrow.h#9792
Open
pctablet505 wants to merge 2 commits into
Open
Conversation
Replace the minimal license comment in src/libImaging/Arrow.h with the full Apache-2.0 header from the upstream Apache Arrow project, including the copyright ownership notice required by section 4(d) of the license. Fixes python-pillow#9657
radarhere
changed the title
Member
|
Why has this been marked as a draft? |
Member
|
I swear we had another pr a week or two back that was doing this as well.
|
Member
Could it have been opened as a draft ? |
Member
|
It was #9787, but that and its creator @muhamedfazalps appear to be no more. |
pctablet505
marked this pull request as ready for review
July 16, 2026 13:25
…urce The definitions in Arrow.h are the free-standing structures published in the Apache Arrow C Data Interface documentation and copied under the Apache License 2.0, not a copy of the upstream abi.h source file. Replace the header with a vendoring note recording the documentation source URL, the license, an SPDX identifier and the copyright holder, matching the style used for other vendored headers such as src/thirdparty/pythoncapi_compat.h, and keep the ARROW_C_DATA_INTERFACE guard exactly as-is. Fixes python-pillow#9657
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9657.
The current header in
src/libImaging/Arrow.honly notes "Apache License 2.0" with a spec link, which is not enough attribution for the vendored Apache-2.0 snippet. This adds the full license header and copyright notice while leaving the struct definitions and theARROW_C_DATA_INTERFACEguard untouched.