Skip to content

Add support for iscsi_set_isid_oui and iscsi_set_isid_en #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmeagherix merged 1 commit into from
Oct 1, 2026
Merged

Add support for iscsi_set_isid_oui and iscsi_set_isid_en #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/iscsi.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@ cdef extern from "iscsi/iscsi.h":
cdef int iscsi_set_header_digest(iscsi_context *iscsi, iscsi_header_digest header_digest)
cdef int iscsi_set_initiator_username_pwd(iscsi_context *iscsi, const char *user, const char *passwd)
cdef int iscsi_set_target_username_pwd(iscsi_context *iscsi, const char *user, const char *passwd)
cdef int iscsi_set_isid_oui(iscsi_context *iscsi, uint32_t oui, uint32_t qualifier)
cdef int iscsi_set_isid_en(iscsi_context *iscsi, uint32_t en, uint32_t qualifier)
cdef int iscsi_full_connect_sync(iscsi_context *iscsi, const char *portal, int lun)
cdef int iscsi_disconnect(iscsi_context *iscsi)

Expand Down Expand Up @@ -142,6 +144,14 @@ cdef class Context:
if iscsi_set_target_username_pwd(self._ctx, user.encode('utf-8'), passwd.encode('utf-8')) < 0:
raise ValueError("Invalid target user/pass: %s" % user)

def set_isid_oui(self, uint32_t oui, uint32_t qualifier):
if iscsi_set_isid_oui(self._ctx, oui, qualifier) < 0:
raise ValueError("Invalid ISID OUI/qualifier: %#x/%#x" % (oui, qualifier))

def set_isid_en(self, uint32_t en, uint32_t qualifier):
if iscsi_set_isid_en(self._ctx, en, qualifier) < 0:
raise ValueError("Invalid ISID EN/qualifier: %#x/%#x" % (en, qualifier))

def connect(self, str portal, int lun):
if iscsi_full_connect_sync(self._ctx, portal.encode('utf-8'), lun) < 0:
raise RuntimeError("Unable to connect to %s" % portal)
Expand Down
5 changes: 5 additions & 0 deletions tests/iscsi_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ def test_set_context_params(self):
context.set_targetname("my-target")
context.set_header_digest(iscsi.iscsi_header_digest.ISCSI_HEADER_DIGEST_NONE)

def test_set_isid(self):
context = iscsi.Context("foobar")
context.set_isid_oui(0x001405, 0x0)
context.set_isid_en(0x001405, 0x0)

def test_command(self):
context = iscsi.Context("foobar")
task = iscsi.Task(
Expand Down
Loading