Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1948.
The example passes
icon_shape="triangle", which is absent from BeautifyMarker's anchor tables and Folium's supported shape list. The missing popup anchor makes clicking the plane throw a JavaScript error. Usecircleand list the supported shapes in the guide and docstring.Verified the original example fails on click, then both popups open without JavaScript errors after this change in Chromium, Firefox and WebKit. The existing Beautify notebook Selenium test passes. Pre-commit passes; documentation builds with one existing toctree warning. Broader checks: 383 regular tests passed with two failures reproduced on the base; Selenium/snapshots had 82 passed, one xfailed and one heatmap screenshot difference also reproduced on the base.
AI assistance was used to investigate, edit and validate this change.