Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Location validation consumes coordinates from single-pass iterators while checking whether the input is empty and whether it contains multiple lines. This silently changes geometry passed to
PolyLine.For example:
Before this change, the result is
[[2.0, 7.0]]: the first two vertices disappear. Single-point iterators become empty, and nested line iterators also lose vertices.Changes
Materialize outer iterators before the validation checks and inner line iterators before checking nesting. Lists, arrays, and DataFrames retain their existing validation paths.
Add regressions for list iterators, generator expressions, single-point inputs, empty iterators, and nested line iterators.
Validation
python -m pytest tests/test_utilities.py tests/test_vector_layers.py tests/plugins/test_marker_cluster.py -q: 95 passed.ruff check folium/utilities.py tests/test_utilities.py: passed.black --check folium/utilities.py tests/test_utilities.py: passed.git diff --check: passed.The full non-Selenium suite was attempted but could not collect unrelated tests because Pillow and GeoPandas were not installed. Browser tests were not run.
Prepared with AI assistance.