gh-151903: Optimize context managers by replacing next() with for loops#152806
Closed
tmvalijib24 wants to merge 4 commits into
Closed
gh-151903: Optimize context managers by replacing next() with for loops#152806tmvalijib24 wants to merge 4 commits into
tmvalijib24 wants to merge 4 commits into
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Member
|
The issue already has an open PR (by Brandt himself), closing in favour of the existing work. |
Author
|
Hi @StanFromIreland, I am New to Open Source and interested in Contributing for Cpython, is there any discord channel in which I can connect to the maintainers and contributors? |
Member
|
I'm afraid there isn't, I suggest reading the devguide. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #151903
Description
This PR optimizes context managers by replacing explicit
next()andanext()iteration calls with structuredforandasync forloops within_GeneratorContextManagerand_AsyncGeneratorContextManagerinsideLib/contextlib.py.Why this helps:
StopIterationorStopAsyncIterationexceptions on successful context blocks.Tests
./python -m test test_contextlib(all tests passed successfully).contextlib.contextmanagerto useforloops instead ofnext#151903