gh-156707: Remove the junction created in test_realpath_volume_guid_path() - #156709
Open
serhiy-storchaka wants to merge 1 commit into
Open
gh-156707: Remove the junction created in test_realpath_volume_guid_path()#156709serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
…guid_path() The junction pointed to a volume without a mount point. It was left for the temporary directory cleanup, which descended into it and tried to remove files on that volume. os.rmdir() removes the junction itself, not the directory it points to.
serhiy-storchaka
added
needs backport to 3.13
Member
|
I prefer the general fix #156710. |
Member
Author
|
It will not harm to apply both fixes, I already applied this fix to #156611, so it will not break buildbots if merged first. |
Member
|
The rmdir() call looks like a workaround for os_helper.rmtree() bug. I don't think that it's needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test created a junction to a volume without a mount point and left it to the temporary directory cleanup, which descended into the junction and tried to remove files on that volume.
os.rmdir()removes the junction itself, not the directory it points to.