Fix the Qwen GQA test failure.#4385
Open
SandSnip3r wants to merge 1 commit into
Open
Conversation
The Qwen GQA test failed in the decomposed variant due to the intemediate between the matmuls being downcast to fp16. Plumb use_fp32_acc through the dynamo backend. Pick a specific seed for the GQA test. Reenable GQA test for fp16.
zewenli98
reviewed
Jul 9, 2026
zewenli98
left a comment
Collaborator
There was a problem hiding this comment.
@SandSnip3r The idea looks good! The decomposed attention path needs the entire computation in FP32, not just matmul.
My only concern is that the definition of use_fp32_acc currently suggests FP32 applies only to matmul, whereas this implementation extends it to the whole attention path. It may help to clarify that in the definition, for example by noting that [op1, op2, ...] will use FP32 for the full computation rather than matmul alone for accuracy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the Qwen GQA test failure.
The Qwen GQA test failed in the decomposed variant due to the intemediate between the matmuls being downcast to fp16. Plumb use_fp32_acc through the dynamo backend.
Pick a specific seed for the GQA test.
Reenable GQA test for fp16.
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: