Skip to content

[cadence] Glob hifi op-test sources so all op tests are picked up#20747

Open
aliafzal wants to merge 1 commit into
mainfrom
cadence-hifi-ops-complete
Open

[cadence] Glob hifi op-test sources so all op tests are picked up#20747
aliafzal wants to merge 1 commit into
mainfrom
cadence-hifi-ops-complete

Conversation

@aliafzal

@aliafzal aliafzal commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Replace the hardcoded test_op_*.cpp list in the cadence_hifi_op_tests target with file(GLOB CONFIGURE_DEPENDS ...), so any op test added to backends/cadence/hifi/operators/tests/ is compiled and run on the Xtensa ISS automatically without editing the CMakeLists.

No behavior change today (globs the same 10 test files currently present); this just removes the manual per-op list so future op tests are picked up automatically.

Replace the hardcoded test_op_*.cpp list in the cadence_hifi_op_tests
target with file(GLOB CONFIGURE_DEPENDS ...) over test_op_*.cpp, so any
op test added to backends/cadence/hifi/operators/tests/ is compiled and
run on the Xtensa ISS automatically without editing this CMakeLists.
@pytorch-bot

pytorch-bot Bot commented Jul 6, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20747

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Cancelled Job, 10 Unrelated Failures

As of commit 7d0b60c with merge base 4dc1b5b (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 6, 2026
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant