Skip to content

arm64: defconfig: Enable CAMSS OPE driver - #1688

Open
Nihal Kumar Gupta (nihal231998) wants to merge 1 commit into
qualcomm-linux:tech/all/configfrom
nihal231998:ope_defconfig
Open

arm64: defconfig: Enable CAMSS OPE driver#1688
Nihal Kumar Gupta (nihal231998) wants to merge 1 commit into
qualcomm-linux:tech/all/configfrom
nihal231998:ope_defconfig

Conversation

@nihal231998

@nihal231998 Nihal Kumar Gupta (nihal231998) commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Add CONFIG_VIDEO_QCOM_CAMSS_OPE=m to enable the Offline Processing Engine driver for Agatti and Shikra platform.

CR-Fixed: 4677262

@qlijarvis

qlijarvis commented Aug 13, 2026

Copy link
Copy Markdown

PR #1688 — validate-patch

PR: #1688

Verdict Issues Detailed Report
✅ 0 Full report

Final Summary

  1. Lore link present: No — PENDING: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor work-in-progress, not posted upstream
  4. PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #1688 - PENDING: arm64: defconfig: Enable CAMSS OPE driver
Upstream commit: N/A (PENDING: prefix - work-in-progress, not yet posted upstream)
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject matches upstream N/A PENDING: prefix - no upstream source to compare
Body preserves rationale ✅ Clear description of change (enable OPE driver for Agatti/Shikra)
Fixes tag present/correct N/A Not a fix commit
Authorship preserved ✅ Proper author and Signed-off-by present
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/configs/defconfig ✅ Single line addition of CONFIG_VIDEO_QCOM_CAMSS_OPE=m in correct alphabetical position

Verdict

Merge as-is. This is a vendor work-in-progress commit that correctly adds the CAMSS OPE driver config option to defconfig. The change is minimal, well-placed alphabetically, and properly documented with the PENDING: prefix indicating it's not yet posted upstream.

Final Summary

  1. Lore link present: No — PENDING: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor work-in-progress, not posted upstream
  4. PR present in qcom-next/topics: Yes — commit present in topics (1/1 commits present per integration_presence_report.md)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 49dbe0dae5cfb7a1eb3434cde6fc7ba37924fe94
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] PENDING: arm64: defconfig: Enable CAMSS OPE driver missing - no subject, patch-id, or full tree-content match found present - all checked added lines are present present

Final Status

overall_status: PASS
present_commits: 1/1
partial_commits: 0/1
missing_commits: 0/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics

@qlijarvis

qlijarvis commented Aug 13, 2026

Copy link
Copy Markdown

PR #1688 — checker-log-analyzer

PR: #1688
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/31681735064

Checker Result Summary
Checker Result Summary
checkpatch ✅ 0 errors, 0 warnings, 0 checks
dt-binding-check ⏭️ No binding changes
dtb-check ⏭️ No devicetree changes
sparse-check ⏭️ No C/H file changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance ❌ PENDING: prefix not in allowed list
tag-check ✅ PENDING: is a valid subject prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1688 - PENDING: arm64: defconfig: Enable CAMSS OPE driver
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/31681735064
Target branch: tech/all/config

Checker Result Summary
checkpatch ✅ 0 errors, 0 warnings, 0 checks
dt-binding-check ⏭️ No binding changes
dtb-check ⏭️ No devicetree changes
sparse-check ⏭️ No C/H file changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance ❌ PENDING: prefix not in allowed list
tag-check ✅ PENDING: is a valid subject prefix

❌ check-patch-compliance

Root cause: The commit uses the PENDING: prefix, which is not in the checker's allowed prefix list (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Failure details:

Checking commit: PENDING: arm64: defconfig: Enable CAMSS OPE driver
Commit summary does not start with a required prefix
##[error]Process completed with exit code 1.

Analysis:

This is a known limitation of the check-patch-compliance checker. The checker only accepts upstream-linkable prefixes:

  • FROMLIST: (posted to mailing list)
  • FROMGIT: (in maintainer tree)
  • UPSTREAM: (merged to mainline)
  • BACKPORT: (backported with modifications)

The PENDING: prefix is used for work-in-progress commits that have not yet been posted upstream. While this is a valid vendor-internal prefix (and passes the mandatory tag-check for non-qcom-next branches), the check-patch-compliance checker will always fail for it.

Fix options:

  1. If the patch has been posted upstream: Change prefix to FROMLIST: and add a Link: trailer pointing to the lore.kernel.org URL:

    git rebase -i <base_sha>   # mark commit as 'edit'
git commit --amend -m "FROMLIST: arm64: defconfig: Enable CAMSS OPE driver"
# Add Link: https://lore.kernel.org/... to commit body
git rebase --continue

  2. If the patch is vendor-only and not posted: The checker will continue to fail. This is expected behavior for PENDING: commits. The failure can be acknowledged as a known limitation.

Reproduce locally:

cd <kernel-tree>
git log --oneline -1 f2f79cbd28a01c56883ac97962c2063ed3bce579
# Check if subject starts with FROMLIST/FROMGIT/UPSTREAM/BACKPORT

✅ tag-check (mandatory for tech/all/config branch)

Status: PASS

The target branch tech/all/config is not qcom-next or qcom-next-staging, so every commit must start with a valid prefix tag. The commit subject PENDING: arm64: defconfig: Enable CAMSS OPE driver correctly starts with PENDING:, which is one of the allowed prefixes:

  • FROMLIST: ✓
  • FROMGIT: ✓
  • UPSTREAM: ✓
  • BACKPORT: ✓
  • QCLINUX: ✓
  • PENDING: ✓ (used in this PR)
  • WORKAROUND: ✓

Verdict

One known limitation blocker:

The check-patch-compliance failure is a known checker limitation for PENDING: prefixed commits. This is not a patch defect.

Recommended actions:

  1. If the CONFIG_VIDEO_QCOM_CAMSS_OPE driver patch has been posted upstream: Update the commit prefix to FROMLIST: and add the lore.kernel.org link.

  2. If this is genuinely a pending/work-in-progress change: The checker failure can be acknowledged and the PR can proceed. The commit correctly follows the mandatory subject-prefix requirement for the tech/all/config branch.

  3. Verify integration status: The integration presence report shows this commit is already present in the topics branches, suggesting this may be a sync/backport operation rather than a new change.

All other checkers passed or correctly skipped (no relevant file changes). The patch itself is clean with no coding style, binding, or ABI issues.

@nihal231998
Nihal Kumar Gupta (nihal231998) marked this pull request as ready for review September 15, 2026 09:21
@qcomlnxci
qcomlnxci requested a review from a team September 15, 2026 09:22
Nihal Kumar Gupta
FROMLIST: arm64: defconfig: Enable CAMSS OPE driver
53e0787 
Add CONFIG_VIDEO_QCOM_CAMSS_OPE=m to enable the Offline Processing Engine
driver for Agatti and Shikra platforms (e.g. Arduino UNO Q).

Signed-off-by: Nihal Kumar Gupta <nihal.gupta@oss.qualcomm.com>
Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
Upstream-Status: Submitted [https://lore.kernel.org/all/20260915-camss-isp-ope-v7-9-77b13d131d3d@oss.qualcomm.com/]
@qlijarvis

qlijarvis commented Sep 20, 2026

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1688

PR: #1688
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35492499214

# Error File:Line PR-introduced? Root Cause
N/A Automerge failure Multiple files (137 conflicts) No Pre-existing merge conflicts between baseline branch (qcom-next) and topic branch (tech/all/config)

Verdict

This PR does not introduce any build errors. The build failed during the automerge step due to 137 pre-existing merge conflicts between the baseline and topic branches. The PR itself only adds one line to arch/arm64/configs/defconfig (enabling CONFIG_VIDEO_QCOM_CAMSS_OPE=m), which merged cleanly without conflicts. No compilation was attempted because the merge failed first.

📎 Detailed analysis: Full report

@qlijarvis

qlijarvis commented Sep 20, 2026

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1688

PR: #1688
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35492499214

# Error File:Line PR-introduced? Root Cause
1 Merge conflict during automerge Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml No Pre-existing merge conflict between baseline (qcom-next) and topic branch (tech/all/config). The PR only modifies arch/arm64/configs/defconfig and does not touch this file.

Verdict

This is not a compilation error. The build failed during the automerge (integration) phase due to a pre-existing merge conflict in an unrelated file. The PR changes are not responsible for this failure.

📎 Detailed analysis: Full report

@qlijarvis

qlijarvis commented Sep 20, 2026

Copy link
Copy Markdown

PR #1688 — validate-patch

PR: #1688

Verdict Issues Detailed Report
⚠️ 0 Full report

Final Summary

  1. Lore link present: Yes — found in Upstream-Status: Submitted [URL] field (non-standard format; should use Link: tag)
  2. Lore link matches PR commits: Cannot verify — lore patch not fetched by Jarvis (only standard Link: tags were detected)
  3. Upstream patch status: Unknown — cannot verify without lore thread access; Upstream-Status: Submitted indicates posted but outcome unknown; patch dated 2026-09-15 (5 days ago, very recent)
  4. PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1688 — FROMLIST: arm64: defconfig: Enable CAMSS OPE driver
Upstream commit: https://lore.kernel.org/all/20260915-camss-isp-ope-v7-9-77b13d131d3d@oss.qualcomm.com/
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream ⚠️ Cannot verify — lore patch not fetched; subject appears reasonable for defconfig change
Body preserves rationale ⚠️ Cannot verify — lore patch not fetched; body explains config purpose and target platforms
Fixes tag present/correct ✅ N/A — defconfig addition, no Fixes tag needed
Authorship preserved ⚠️ Cannot verify original author — lore patch not fetched; FROMLIST allows submitter in From: if original author has SoB
Backport note (if applicable) N/A Not a backport — FROMLIST prefix indicates pending upstream patch

Diff

File Status Notes
arch/arm64/configs/defconfig ⚠️ Cannot verify match to upstream — lore patch not fetched; single-line config addition appears clean

Issues

  1. Non-standard lore link format: The commit uses Upstream-Status: Submitted [URL] instead of the kernel-standard Link: tag. Recommended format:

    Link: https://lore.kernel.org/r/20260915-camss-isp-ope-v7-9-77b13d131d3d@oss.qualcomm.com

  2. Lore evidence not fetched: Jarvis only detected standard Link: tags and did not fetch the lore patch referenced in Upstream-Status. Cannot verify:

    • Diff faithfulness to upstream posting
    • Original author identity
    • Upstream patch status (ACKed/NACKed/Pending)

  3. Patch is part of a series: The message-ID indicates this is patch 9 of a v7 series (camss-isp-ope-v7-9). Dependency check: verify that patches 1-8 are either already in the tree or included in related PRs.

Verdict

Conditional approval — The commit structure is reasonable for a FROMLIST defconfig addition, and integration presence check confirms it's in topics. However, full validation requires:

  1. Fetching the lore patch to verify diff match and authorship
  2. Confirming upstream status (submitted 5 days ago on 2026-09-15)
  3. Verifying series dependencies (patches 1-8 of the v7 series)

Recommend: Update Upstream-Status to standard Link: tag format, then re-validate with lore evidence.

Final Summary

  1. Lore link present: Yes — found in Upstream-Status: Submitted [URL] field (non-standard format; should use Link: tag)
  2. Lore link matches PR commits: Cannot verify — lore patch not fetched by Jarvis (only standard Link: tags were detected)
  3. Upstream patch status: Unknown — cannot verify without lore thread access; Upstream-Status: Submitted indicates posted but outcome unknown; patch dated 2026-09-15 (5 days ago, very recent)
  4. PR present in qcom-next/topics: Yes — present in topics; all added lines found (per integration_presence_report.md)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: d49c33864d06e9672dce57738be8851384578fcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] FROMLIST: arm64: defconfig: Enable CAMSS OPE driver missing - no subject, patch-id, or full tree-content match found present - all checked added lines are present present

Final Status

overall_status: PASS
present_commits: 1/1
partial_commits: 0/1
missing_commits: 0/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics

@qlijarvis

qlijarvis commented Sep 20, 2026

Copy link
Copy Markdown

PR #1688 — checker-log-analyzer

PR: #1688
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35492499403

Checker Result Summary
Checker Result Summary
checkpatch ⚠️ CI infrastructure failure (automerge conflict)
dt-binding-check ⚠️ CI infrastructure failure (automerge conflict)
dtb-check ⚠️ CI infrastructure failure (automerge conflict)
sparse-check ⚠️ CI infrastructure failure (automerge conflict)
check-uapi-headers ⚠️ CI infrastructure failure (automerge conflict)
check-patch-compliance ⚠️ CI infrastructure failure (automerge conflict) + predicted Link: trailer issue
tag-check ✅ Subject has valid FROMLIST: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1688 - FROMLIST: arm64: defconfig: Enable CAMSS OPE driver
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/35492499403

Checker Result Summary
checkpatch ⚠️ CI infrastructure failure (automerge conflict)
dt-binding-check ⚠️ CI infrastructure failure (automerge conflict)
dtb-check ⚠️ CI infrastructure failure (automerge conflict)
sparse-check ⚠️ CI infrastructure failure (automerge conflict)
check-uapi-headers ⚠️ CI infrastructure failure (automerge conflict)
check-patch-compliance ⚠️ CI infrastructure failure (automerge conflict) + predicted Link: trailer issue
tag-check ✅ Subject has valid FROMLIST: prefix

⚠️ CI Infrastructure Failure — Automerge Conflict

Root cause: All checker jobs failed during the automerge stage due to a merge conflict in Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml, which is unrelated to this PR's changes.

Failure details:

Normal merge conflict for 'Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml':
  {local}: modified file
  {remote}: modified file
automerge returned non-zero; check logs for conflicts
##[error]Process completed with exit code 1.

Analysis:

  • This PR only modifies arch/arm64/configs/defconfig (adds one line: CONFIG_VIDEO_QCOM_CAMSS_OPE=m)
  • The conflict is in a completely different file (Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml)
  • This is a CI infrastructure issue, not a problem with the PR itself
  • The conflict occurred when the CI attempted to merge the PR branch with the target base branch (likely qcom-next or a topic branch)

Fix:

  1. Rebase the PR branch on the latest target branch to resolve the conflict:

    git fetch origin <target-branch>
git rebase origin/<target-branch>
# Resolve the conflict in qcom,coresight-ctcu.yaml
git add Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml
git rebase --continue
git push --force-with-lease

  2. Or wait for the base branch to stabilize — if other PRs are being merged that touch the same file, the conflict may resolve itself.

  3. Re-trigger CI after resolving the conflict.

❌ check-patch-compliance (Predicted Failure)

Root cause: The commit uses Upstream-Status: trailer instead of the required Link: trailer for FROMLIST: commits.

Failure details:

Subject: FROMLIST: arm64: defconfig: Enable CAMSS OPE driver
Upstream-Status: Submitted [https://lore.kernel.org/all/20260915-camss-isp-ope-v7-9-77b13d131d3d@oss.qualcomm.com/]

The check-patch-compliance checker expects:

Link: https://lore.kernel.org/all/20260915-camss-isp-ope-v7-9-77b13d131d3d@oss.qualcomm.com/

Analysis:

  • FROMLIST: commits must have a Link: trailer pointing to the lore.kernel.org patch
  • The commit currently uses Upstream-Status: Submitted [URL] format (Yocto/OE convention)
  • The kernel upstream convention is Link: <URL> (no brackets, no "Submitted" text)
  • Once the automerge conflict is resolved and CI runs, check-patch-compliance will fail with: 
    No 'Link' found in commit message

Fix:

git rebase -i <base_sha>   # mark commit as 'edit'
git commit --amend
# Change the commit message from:
#   Upstream-Status: Submitted [https://lore.kernel.org/all/20260915-camss-isp-ope-v7-9-77b13d131d3d@oss.qualcomm.com/]
# To:
#   Link: https://lore.kernel.org/all/20260915-camss-isp-ope-v7-9-77b13d131d3d@oss.qualcomm.com/
git rebase --continue
git push --force-with-lease

Reproduce locally:

cd kernel
./scripts/check-patch-compliance.sh <base_sha> <head_sha>

✅ Patch Content Analysis

What the PR does:

  • Adds CONFIG_VIDEO_QCOM_CAMSS_OPE=m to arch/arm64/configs/defconfig
  • Enables the Offline Processing Engine (OPE) driver for Qualcomm CAMSS
  • Targets Agatti and Shikra platforms (e.g., Arduino UNO Q)

Patch quality:

  • ✅ Subject prefix: FROMLIST: (valid)
  • ✅ Subject length: 52 characters (under 75-char limit)
  • ✅ Signed-off-by: Present (2 signatures)
  • ✅ File change: Single-line addition to defconfig (clean, focused)
  • ✅ Alphabetical ordering: Correctly placed after CONFIG_VIDEO_QCOM_CAMSS=m
  • ❌ Link trailer: Missing (uses Upstream-Status: instead)

Verdict

2 blockers to fix before merge:

  1. Automerge conflict — Rebase on the latest target branch to resolve the conflict in Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml

  2. Link trailer format — Replace Upstream-Status: Submitted [URL] with Link: URL to satisfy check-patch-compliance

After fixing both issues:

  • Re-trigger CI
  • All checkers should pass (the patch itself is clean and follows kernel conventions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndechesne Nicolas Dechesne (ndechesne) Awaiting requested review from ndechesne ndechesne was automatically assigned from qualcomm-linux/qualcomm-kernel-maint
@Komal-Bajaj Komal Bajaj (Komal-Bajaj) Awaiting requested review from Komal-Bajaj Komal-Bajaj was automatically assigned from qualcomm-linux/qualcomm-kernel-maint
@mukeshojha-linux Mukesh Ojha (mukeshojha-linux) Awaiting requested review from mukeshojha-linux mukeshojha-linux was automatically assigned from qualcomm-linux/qualcomm-kernel-maint

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nihal231998 @qlijarvis