Skip to content

QCLINUX: arm64: dts: qcom: Enable AON camera support for Glymur CRD - #1860

Open
Vishal Verma (vishverm-qli) wants to merge 1 commit into
qualcomm-linux:tech/overlay/dtfrom
vishverm-qli:glymur-dt-change
Open

Vishal Verma (vishverm-qli) wants to merge 1 commit into
qualcomm-linux:tech/overlay/dtfrom
vishverm-qli:glymur-dt-change

Conversation

@vishverm-qli

@vishverm-qli Vishal Verma (vishverm-qli) commented Sep 20, 2026

Copy link
Copy Markdown

Enable EGPIO ownership for the AON camera shared pins, including CCI,
reset, and MCLK, by adding qcom,apps and qcom,remote flags.

CRs-Fixed: 4683190

Enable EGPIO ownership for the AON camera shared pins, including CCI,
reset, and MCLK, by adding qcom,apps and qcom,remote flags.

Signed-off-by: Vishal Verma <vishverm@qti.qualcomm.com>
@qcomlnxci
qcomlnxci requested review from a team, Amit Kucheria (idlethread), jingyiwang42 and Shiraz Hashim (shashim-quic) and removed request for a team September 20, 2026 21:56
@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1860

PR: #1860
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35540142362

# Error File:Line PR-introduced? Root Cause
N/A Automerge failure: 154 merge conflicts Multiple files No Pre-existing integration conflicts between tech/overlay/dt branch and qcom-next baseline

Verdict

This is NOT a build failure caused by PR #1860. The build failed during the automerge step due to 154 pre-existing merge conflicts between the PR's base branch (tech/overlay/dt) and the integration baseline (qcom-next). The PR itself only modifies arch/arm64/boot/dts/qcom/glymur-camera.dtsi, which is not involved in any of the conflicts. No compilation was attempted.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1860

PR: #1860
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35540142362

# Error File:Line PR-introduced? Root Cause
1 Automerge conflict 150 files (see detailed analysis) No Pre-existing merge conflicts between integration base and topic/tech/overlay/dt branch

Verdict

0 of 150+ merge conflicts are introduced by this PR; all are pre-existing integration issues.

The PR modifies only arch/arm64/boot/dts/qcom/glymur-camera.dtsi, which is NOT among the conflicting files. The build failure occurred during the automerge phase when attempting to merge the topic/tech/overlay/dt topic branch into the integration base, before the PR changes were even applied.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #1860 — validate-patch

PR: #1860

Verdict Issues Detailed Report
⚠️ 0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

Note: While this commit does not require upstream validation, the integration presence check indicates it has not yet been merged into the target integration branches. This should be verified before merging the PR.

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1860 - QCLINUX: arm64: dts: qcom: Enable AON camera support for Glymur CRD
Upstream commit: N/A (vendor-only commit)
Verdict: ⚠️ N/A - QCLINUX vendor-only commit

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: vendor-only commit
Body preserves rationale Clear description of EGPIO ownership changes
Fixes tag present/correct N/A Not a fix commit
Authorship preserved Signed-off-by present
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/glymur-camera.dtsi Adds qcom,apps and qcom,remote flags to camera pin configurations

Issues

None - this is a vendor-specific device tree change for AON camera support on Glymur CRD. The commit message clearly describes the purpose (enabling EGPIO ownership for AON camera shared pins), and the diff consistently adds the required flags across multiple pin configurations.

Verdict

This is a vendor-only commit (QCLINUX: prefix) that does not require upstream validation. The commit is properly formatted with clear rationale and appropriate Signed-off-by trailer. However, note that the integration presence report shows this commit is missing from both qcom-next and topics branches, which may indicate it has not yet been integrated into the target branch.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail — commit is missing from both qcom-next and topics (per integration_presence_report.md: "1/1 commit(s) are missing from both qcom-next and topics")

Note: While this commit does not require upstream validation, the integration presence check indicates it has not yet been merged into the target integration branches. This should be verified before merging the PR.

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: d49c33864d06e9672dce57738be8851384578fcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] QCLINUX: arm64: dts: qcom: Enable AON camera support for missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1860 — checker-log-analyzer

PR: #1860
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35540142649

Checker Result Summary
Checker Result Summary
checkpatch ⏭️ Skipped - automerge conflict
dt-binding-check ⏭️ Skipped - automerge conflict
dtb-check ⏭️ Skipped - automerge conflict
sparse-check ⏭️ Skipped - automerge conflict
check-uapi-headers ⏭️ Skipped - automerge conflict
check-patch-compliance ⏭️ Skipped - automerge conflict
tag-check PASS - commit has valid QCLINUX: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1860 - QCLINUX: arm64: dts: qcom: Enable AON camera support for Glymur CRD
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/35540142649

Checker Result Summary
checkpatch ⏭️ Skipped - automerge conflict
dt-binding-check ⏭️ Skipped - automerge conflict
dtb-check ⏭️ Skipped - automerge conflict
sparse-check ⏭️ Skipped - automerge conflict
check-uapi-headers ⏭️ Skipped - automerge conflict
check-patch-compliance ⏭️ Skipped - automerge conflict
tag-check PASS - commit has valid QCLINUX: prefix

⚠️ CI Infrastructure Issue: Automerge Conflict

Root cause: All checker jobs failed during the automerge phase due to a merge conflict in Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml, preventing any actual checker validation from running.

Failure details:

Normal merge conflict for 'Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml':
  {local}: modified file
  {remote}: modified file
automerge returned non-zero; check logs for conflicts
##[error]Process completed with exit code 1.

Analysis:
This is a CI infrastructure/workflow issue, not a problem with the PR patch itself. The PR modifies only arch/arm64/boot/dts/qcom/glymur-camera.dtsi (adding qcom,apps and qcom,remote properties to camera pinctrl nodes), but the CI automerge step encountered a conflict in an unrelated file (Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml).

This conflict is between the PR's base branch and the target branch, indicating that:

  1. The base branch has diverged from the target branch
  2. Another PR or commit modified qcom,coresight-ctcu.yaml in the target branch after this PR's base was established
  3. The automerge step (which merges the PR into the current target branch state) cannot proceed automatically

Fix:
The PR author needs to rebase the PR branch onto the latest target branch to resolve the conflict:

# In the PR branch
git fetch origin
git rebase origin/<target-branch>

# If conflicts occur during rebase:
git status  # identify conflicted files
# Manually resolve conflicts in Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml
git add <resolved-files>
git rebase --continue

# Force-push the rebased branch
git push --force-with-lease

Note: Since the PR itself only touches glymur-camera.dtsi, the conflict resolution should be straightforward — the PR author should accept the target branch's version of qcom,coresight-ctcu.yaml (as the PR doesn't intend to modify it).

Reproduce locally:

# Clone the repo and checkout the PR
git fetch origin pull/1860/head:pr-1860
git checkout pr-1860

# Attempt to merge with target branch
git fetch origin <target-branch>
git merge origin/<target-branch>
# This will reproduce the conflict

✅ tag-check — PASS

Analysis:
The commit subject starts with QCLINUX:, which is a valid prefix tag indicating a vendor-only change with no upstream equivalent.

Note: While QCLINUX: is a valid prefix for the tag-check, it will cause check-patch-compliance to fail (as that checker only accepts FROMLIST:, FROMGIT:, UPSTREAM:, and BACKPORT: prefixes). However, since all checkers were skipped due to the automerge conflict, we cannot confirm whether check-patch-compliance would have failed for this reason.


Verdict

Cannot assess patch quality — all checkers were blocked by an automerge conflict in an unrelated file. The PR must be rebased onto the latest target branch before checkers can run.

Action required: Rebase PR #1860 onto the latest target branch to resolve the qcom,coresight-ctcu.yaml conflict, then re-trigger CI.

@qswat-orbit-external

Copy link
Copy Markdown

Dev Completion validation failed

CR: 4683190
Change Task: kernel.qli.0.0
Error: Failed to validate change task completion. Status code: NotFound

The change task for this CR could not be moved to Dev Complete because of the error above. Please resolve the issue in Orbit and re-run the failed Orbit check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants