meta-qcom: add RTSS mailbox DLKM/UMD recipes (phase 1) - #3084
sargarram7 wants to merge 3 commits into
Conversation
|
Check-layer is failing. |
7b0844d to
09b4afd
Compare
|
Squash the changes, you don't need multiple patches fixing the same recipe here. And it is still failing. |
09b4afd to
92922bc
Compare
Ricardo Salveti (@ricardosalveti) thank you for capturing this , check layer issue is fixed |
Dmitry Baryshkov (lumag)
left a comment
There was a problem hiding this comment.
Also. PLEASE, STOP MOVING THE TAGS.
Once tagged, it should stay as is. You can't push a new tag just because. If you changed the code in the repo, it's a new tag.
Test Results 68 files ± 0 319 suites ±0 2h 42m 51s ⏱️ - 1h 50m 7s For more details on these failures, see this check. Results for commit 62a4c9b. ± Comparison against base commit f497678. This pull request removes 13 tests.♻️ This comment has been updated with latest results. |
|
Moving to draft until the required kernel changes are in place. |
| LICENSE = "GPL-2.0-only" | ||
| LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e" | ||
|
|
||
| SRC_URI = "git://github.com/qualcomm-linux/rtss-mailbox-kmd.git;branch=rtss-mailbox-kernel.le.0.0;protocol=https;tag=v${PV}" |
1c46326 to
452a6f1
Compare
452a6f1 to
f77a92b
Compare
|
|
||
| RRECOMMENDS:${PN} += "kernel-module-rtss-mailbox" | ||
|
|
||
| FILES:${PN} = "${libdir}/librtss_mailbox.so.* ${libdir}/librtss_safemlib.so.* ${libdir}/librtss_update.so.* ${libdir}/librtss_gpt.so.*" |
There was a problem hiding this comment.
Why do you need this list?
| RRECOMMENDS:${PN} += "kernel-module-rtss-mailbox" | ||
|
|
||
| FILES:${PN} = "${libdir}/librtss_mailbox.so.* ${libdir}/librtss_safemlib.so.* ${libdir}/librtss_update.so.* ${libdir}/librtss_gpt.so.*" | ||
| FILES:${PN}-utils = "${bindir}/rtss_dbg ${bindir}/rtss_console ${bindir}/rtss_mbdemo ${bindir}/rtss_updater" |
There was a problem hiding this comment.
Just ${bindir}?
| FILES:${PN} = "${libdir}/librtss_mailbox.so.* ${libdir}/librtss_safemlib.so.* ${libdir}/librtss_update.so.* ${libdir}/librtss_gpt.so.*" | ||
| FILES:${PN}-utils = "${bindir}/rtss_dbg ${bindir}/rtss_console ${bindir}/rtss_mbdemo ${bindir}/rtss_updater" | ||
|
|
||
| COMPATIBLE_MACHINE = "qcs8300|qcs9100" |
There was a problem hiding this comment.
No, userspace components can be built with any machine.
cdb12bf to
e797282
Compare
e797282 to
c025f94
Compare
c025f94 to
e77b5d6
Compare
Add the qcom-rtss-mailbox-dlkm recipe to build the RTSS mailbox kernel driver (DLKM), exposing the IPC path between APSS and RTSS via /dev/rtssmb with DAC support using rtssmb group. Also add qcom-rtss-mailbox-uapi-headers to package the ioctl/struct UAPI (rtss_mailbox_uapi.h) standalone, so userspace can build against it without depending on the kernel module recipe. Both recipes share SRC_URI/SRCREV/LICENSE via qcom-rtss-mailbox-module-common.inc, since they come from the same upstream tree (rtss-mailbox-kmd). NOTICE: this driver is still being upstreamed and its uAPI (rtss_mailbox_uapi.h) is not yet frozen and may change before upstream acceptance -- see rtss-mailbox-kmd's README for details. The "rtssmb" DAC group name is likewise not guaranteed stable long term -- it may be renamed or split per-pipe if/when this driver moves to per-use-case device nodes. Signed-off-by: Ram Sargar <rsargar@qti.qualcomm.com>
Add the qcom-rtss-mailbox-umd recipe, which builds the userspace middleware and tools for RTSS mailbox IPC communication between APSS and RTSS. This produces the shared libraries that mediate access to the qcom-rtss-mailbox-dlkm kernel driver, along with command-line utilities packaged separately in qcom-rtss-mailbox-umd-utils. It depends on qcom-rtss-mailbox-uapi-headers for the shared ioctl/struct definitions and recommends kernel-module-rtss-mailbox at runtime. Signed-off-by: Ram Sargar <rsargar@qti.qualcomm.com>
…RRECOMMENDS
Add qcom-rtss-mailbox-dlkm and qcom-rtss-mailbox-umd-utils via
MACHINE_EXTRA_RRECOMMENDS in qcom-qcs8300.inc, qcom-qcs9100.inc, and
qcom-armv8a.conf instead, alongside the existing
packagegroup-qcom-boot-additional entry. This mechanism feeds
packagegroup-machine-base, which sets PACKAGE_ARCH = "${MACHINE_ARCH}"
and is machine-specific, so it carries no allarch signature.
Signed-off-by: Ram Sargar <rsargar@qti.qualcomm.com>
e77b5d6 to
62a4c9b
Compare
|
Hi Ricardo Salveti (@ricardosalveti), Jose Quaresma (@quaresmajose) , Could you please approve this PR? additional approval required to complete review. Thank you, |
Jose Quaresma (quaresmajose)
left a comment
There was a problem hiding this comment.
LGTM
The PR is still in drat; please mark it as ready for review.
|
Please rebase in order to run over another testing round. |
Target milestone: QLI-2.1
Background
Customer use cases driving this - CAN communication, RTSS-to-HLOS userspace communication, OTA updates, and on-device programming/flashing. all need working IPC path between the application processor and RTSS. That path doesn't exist upstream today. This is phase 1 of bringing the downstream, out-of-tree RTSS mailbox stack into the open-source tree to support these IPC use cases going forward.
Tracking issue:
#3085
This PR dependency
Related PRs
This is part of a set of PRs bringing the RTSS mailbox stack into the open-source tree:
qcom,rtss-mailbox):RTSS interface enablement is handled using a staging DTBO overlay to carry the rtss mailbox node, both bootup and DTBO patching with it applied have been verified on target.
Testing