flash: support optional boot_bin_immutable_url in targets.json - #232
Open
Phanendra Yarra (phanendra-qc) wants to merge 4 commits into
Open
Phanendra Yarra (phanendra-qc) wants to merge 4 commits into
Phanendra Yarra (phanendra-qc) wants to merge 4 commits into
Conversation
Contributor
|
Reviewed the parser and download changes, and tested the flow locally with the real main and immutable archives for all four targets. The contents are merged correctly, shared URLs are downloaded only once, and targets without |
PR qualcomm-linux/meta-qcom#3069 splits the boot binaries archive into a main zip and a companion immutable zip. The Yocto recipe deploys both into the same DEPLOYDIR; mirror that behaviour here. Changes: - parse-boards-config.py: add boot_bin_immutable_url as an optional field (defaults to "") in the schema doc and setdefault block - download-boot-bins.sh: extract the download+extract logic into a reusable download_and_extract() helper (URL deduplication cache preserved). After the main archive is placed in bins_<board>/, if boot_bin_immutable_url is set the immutable archive is downloaded (also deduplicated) and its contents are merged into the same bins_<board>/ directory via cp -a. Targets without boot_bin_immutable_url are fully backward-compatible. Companion change: qualcomm-linux/qcom-distro-images dev/bootbins-immutable-split Signed-off-by: Phanendra yarra <pyarra@qti.qualcomm.com>
The _extract_* and *_flat scratch directories used during archive extraction were cached in URL_TO_EXTRACTED_DIR for deduplication but never removed. Add a cleanup loop after all boards are processed to rm -rf every cached temp dir, keeping the output directory tidy. Signed-off-by: Phanendra yarra <pyarra@qti.qualcomm.com>
Phanendra Yarra (phanendra-qc)
force-pushed
the
dev/bootbins-immutable-split
branch
from
September 16, 2026 07:25
9234f5b to
b7f91b7
Compare
Author
Thanks for review, addressed DCO & also added cleanup of extact* folder post bin_ created |
Bjordis Collaku (bjordiscollaku)
previously approved these changes
Sep 17, 2026
…targets For targets like iq-x7181-evk that have spinor storage, the flat boot bins archive contains spinor-only firmware. The previous fallback logic copied the entire flat archive root into every storage dir (nvme, ufs, spinor), polluting nvme/ufs flash dirs with spinor-specific binaries. Fix: when no storage-specific subdir exists in the archive and the target has spinor, skip the flat-root fallback for non-spinor storage types. nvme/ufs dirs now receive only ptool-generated partition files and OS images (efi.bin, rootfs.img) as intended. Targets without spinor (iq-8275-evk, iq-9075-evk, qcs6490-rb3gen2) are unaffected — their HAS_SPINOR=false path still falls back to the flat archive root. Signed-off-by: Phanendra yarra <pyarra@qti.qualcomm.com>
Phanendra Yarra (phanendra-qc)
force-pushed
the
dev/bootbins-immutable-split
branch
from
September 19, 2026 05:20
63dc455 to
86db5ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR qualcomm-linux/meta-qcom#3069 splits the boot binaries archive into a main zip and a companion immutable zip. The Yocto recipe deploys both into the same
DEPLOYDIR; this PR mirrors that behaviour in the Ubuntu build pipeline.Changes
flash/parse-boards-config.pyboot_bin_immutable_urlas an optional field (defaults to"") in the schema doc comment and thesetdefaultnormalization block.flash/download-boot-bins.shdownload_and_extract()helper (URL deduplication cache preserved).bins_<board>/, ifboot_bin_immutable_urlis set the immutable archive is downloaded (also deduplicated) and its contents are merged into the samebins_<board>/directory viacp -a— exactly mirroring what the Yocto recipe does.boot_bin_immutable_urlare fully backward-compatible.Dependency
Companion PR in qcom-distro-images: #138 — adds
boot_bin_immutable_urland bumps versions inconfig/resolute/iot/targets.json.