Repository navigation
ci: fix build and check-run jobs being skipped for fork PRs - #34
Merged
Merged
Conversation
When a fork PR triggers this workflow, approve-internal is skipped (expected) and approve-fork succeeds after maintainer approval. The init job uses if: always() to break skip propagation for itself, but the downstream build and check-run jobs had no such guard — GitHub propagates the skip transitively through the needs chain, so both jobs were silently skipped even though init had succeeded. Add if: always() && needs.init.result == 'success' to the build job and if: always() && needs.build.result == 'success' to check-run so that skip propagation is broken at each step. Also promote the build result guard from a step-level condition inside check-run up to the job level, avoiding spinning up a runner only to skip all steps. Signed-off-by: Hasibur Rahman Mohammed <hasiburr@qti.qualcomm.com>
Hasibur Rahman Mohammed (hasiburr-qti)
requested review from
NaveenCherukuri (CherukuriNaveenQC) and
GirishKadirisani
as code owners
September 23, 2026 06:15
GirishKadirisani
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a fork PR triggers
Camera_Service_Compilation_PR, GitHub's skip propagation causesbuildandcheck-runto be silently skipped even after a maintainer approves the run.Root cause: GitHub propagates the
skippedstatus transitively through theneedschain.approve-internalis correctly skipped for fork PRs, andinitcorrectly usesif: always()to break that propagation for itself — butbuildandcheck-runhad no such guard, so the skip bled through again.Fix
if: always() && needs.init.result == 'success'to thebuildjobif: always() && needs.build.result == 'success'to thecheck-runjobcheck-runup to the job level (avoids spinning up a runner only to skip all steps)