Skip to content

Change cirq_google Engine.run and EngineProcessor.run to return a non-blocking EngineJob - #8539

Open
arettig wants to merge 1 commit into
quantumlib:mainfrom
arettig:engine-run-returns-job
Open

arettig wants to merge 1 commit into
quantumlib:mainfrom
arettig:engine-run-returns-job

Conversation

@arettig

@arettig arettig commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Closes #8454

This changes cirq_google.Engine.run() and cirq_google.EngineProcessor.run() to return an EngineJob immediately, rather than blocking to return a result. This should be more convenient and matches both EngineProgram and the run_sweep methods.

The cirq_google Engine.run and EngineProcessor.run used to block and
return a result. They now return a job immediately to better match
EngineProgram and their own run_sweep methods.
@arettig
arettig requested review from a team as code owners November 20, 2026 04:00
@github-actions github-actions Bot added the size: M 50< lines changed <250 label Nov 20, 2026
@arettig

arettig commented Nov 20, 2026

Copy link
Copy Markdown
Contributor Author

I tested this locally to confirm the run() methods are now non-blocking.

@codecov

codecov Bot commented Nov 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.58%. Comparing base (181d009) to head (ba6db61).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8539   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files        1137     1137           
  Lines      105261   105268    +7     
=======================================
+ Hits       104826   104833    +7     
  Misses        435      435           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: M 50< lines changed <250

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cirq_google.Engine.run() and cirq_google.EngineProcessor.run() should return a cirq_google.EngineJob

1 participant