Conversation
Run the Docker image as a non-root user. Execute compiler commands with shell=False and shlex tokenization. Harden SDK XML parsing by rejecting DTDs and external entities. Signed-off-by: vbaddi <vbaddi@qti.qualcomm.com>
| if base_version_element is not None: | ||
| qaic_sdk_version = base_version_element.text | ||
| except ET.ParseError as e: | ||
| parser = expat.ParserCreate() |
Contributor
There was a problem hiding this comment.
This piece of code looks repeated in both files _util.py and nightly_email_report.py. Can unify it at one place and import in other file.
|
|
||
| ``Mandatory`` Args: | ||
| :process (str): Process name for which command is executed. | ||
| :command (str): Command to be executed on shell. |
Contributor
There was a problem hiding this comment.
Update this doc string
quic-hemagnih
requested changes
Sep 22, 2026
quic-hemagnih
left a comment
quic-hemagnih
left a comment
Contributor
There was a problem hiding this comment.
Please take a look at the comments provided in the PR and also add the unit-test.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run the Docker image as a non-root user and Execute compiler commands with shell=False and shlex tokenization. Harden SDK XML parsing by rejecting DTDs and external entities.