Skip to content

fix(sidebar): adjust height and padding for sidebar elements - #513

Merged
qxcnm merged 2 commits into
qxcnm:mainfrom
Jack251970:fix/sidebar-brand-hover-spacing
Oct 26, 2026
Merged

qxcnm merged 2 commits into
qxcnm:mainfrom
Jack251970:fix/sidebar-brand-hover-spacing

Conversation

@Jack251970

Copy link
Copy Markdown
Contributor

变更摘要

  • Adjust height and padding for sidebar elements
image image

改动范围

  • Frontend
  • Desktop / Tauri
  • Service
  • Gateway / Protocol Adapter
  • Docs / Governance
  • Workflow / Release

主要文件

验证

  • pnpm -C apps run test
  • pnpm -C apps run build
  • pnpm -C apps run test:ui
  • cargo test --workspace
  • 其他本地验证已说明

已执行的实际验证:


未执行的验证与原因:


风险与影响面

备注

  • 提交前请确认未包含敏感 token、cookie、API key

Copilot AI balanced review requested due to automatic review settings October 25, 2026 08:46

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The existing sidebar regression test still asserts the previous height and needs updating to match the intended layout.

1 open issue
What changed in this PR

This PR adjusts the sidebar’s brand area height and spacing in the frontend layout.

Changes:

  • Replace the fixed 50px header height with h-16.
  • Add horizontal padding to the brand button when expanded, preserving zero padding when collapsed.
File Description
apps/​src/​components/​layout/​sidebar.tsx Adjust sidebar header height and expanded brand-button padding.

Review effort: Balanced

Comment thread apps/src/components/layout/sidebar.tsx
@qxcnm

qxcnm commented Oct 26, 2026 •

Copy link
Copy Markdown
Owner

已补充提交 f5712442,将现有短窗口侧栏回归测试的高度断言同步到本 PR 的 h-16,原先 CI 中唯一失败的断言已修复。

本地验证:

  • pnpm -C apps run test:runtime:319/319 通过。
  • pnpm -C apps exec playwright test tests/shell-layout.spec.ts tests/codex-cli-onboarding.spec.ts --grep 'short desktop|collapsed sidebar' --reporter=line:2/2 通过;其 webServer 启动步骤执行了 pnpm run build:desktop 静态构建。
  • git diff --check:通过。

短窗口最后一项导航可达、收起侧栏后的品牌按钮行为均验证通过,更新提交的 4 项 CI 已全部通过,已 squash 合并为 d4ebcab7。

@qxcnm
qxcnm merged commit d4ebcab into qxcnm:main Oct 26, 2026
4 checks passed
@Jack251970
Jack251970 deleted the fix/sidebar-brand-hover-spacing branch October 26, 2026 10:43
@Jack251970
Jack251970 restored the fix/sidebar-brand-hover-spacing branch October 26, 2026 10:43
@Jack251970
Jack251970 deleted the fix/sidebar-brand-hover-spacing branch October 26, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants