feat: Openstack sync operator - #2205
Draft
haseebsyed12 wants to merge 1 commit into
Draft
Conversation
haseebsyed12
force-pushed
the
openstack-sync-operator
branch
2 times, most recently
from
August 10, 2026 16:44
fbb02c6 to
abb7bba
Compare
cardoe
requested changes
Aug 10, 2026
Comment on lines
+29
to
+30
| - name: routerFlavors.config | ||
| path: {{ $routerFlavorsConfig }} |
Contributor
There was a problem hiding this comment.
Remove this. Those should just be regular CRDs and we'll load those a different way.
| @@ -0,0 +1,43 @@ | |||
| [ | |||
Contributor
There was a problem hiding this comment.
This data should be separate from the deploy of the operator. And should be a CRD.
| - name: NEUTRON_ROUTER_FLAVOR_SYNC_CRONTAB | ||
| value: {{ .Values.routerFlavors.crontab | quote }} | ||
| - name: NEUTRON_ROUTER_FLAVOR_PRUNE | ||
| value: {{ .Values.routerFlavors.prune | quote }} |
Contributor
There was a problem hiding this comment.
This is too specific for this case. It just needs to generically watch CRDs.
| mountPath: {{ .Values.routerFlavors.mountPath | quote }} | ||
| subPath: {{ .Values.routerFlavors.configMapKey | quote }} | ||
| readOnly: true | ||
| {{- end }} |
haseebsyed12
force-pushed
the
openstack-sync-operator
branch
9 times, most recently
from
August 11, 2026 09:44
74891a2 to
1394a2a
Compare
haseebsyed12
force-pushed
the
openstack-sync-operator
branch
from
August 11, 2026 09:52
1394a2a to
a35b135
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.