Add shared UI action model and generated panel help - #217
Merged
raiseCatError merged 1 commit intoSep 30, 2026
Merged
Conversation
This was referenced Sep 29, 2026
raiseCatError
added this pull request to stack #228
September 29, 2026 22:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #166.
Stacked on #203 (
feature/173-deterministic-presentation). Merge #203 first, then retarget this PR todev.What changed
src/ui/actions.ts: a smallUiActionmodel (stable id, label, help key label, bound key kinds, enabled state) withresolveAction,enabledActionsandrenderActionHelp. Footers list only enabled actions.paletteActions; Run and move are hidden when there is nothing to run or move over.DRAFT_PANEL_ACTIONSinstead of three copies of the same footer.Scope
Verification
Focused tests in
tests/uiActions.test.ts(disabled actions, keyboard completeness, narrow width, palette help). Full suite 625/625, typecheck, build andgit diff --checkclean.