Skip to content

fix: Ensure protospec compilation doesnt improperly cache build flags #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
finger563 merged 1 commit into from
Sep 18, 2026
Merged

fix: Ensure protospec compilation doesnt improperly cache build flags #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions Source/URLab/URLab.Build.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,19 @@ protected void AddProtospec(ReadOnlyTargetRules Target)
string Root = Path.Combine(ThirdPartyPath, "protospec");
string IncludePath = Path.Combine(Root, "include");
string LibPath = Path.Combine(Root, "lib");

// UBT caches the makefile and only re-evaluates this Build.cs when a
// registered dependency changes. Staging ProtoSpec creates files but
// touches nothing UBT already watches (the drift checks watch the git
// index and each dep's INSTALLED_SHA.txt, none of which move), so without
// these the next build silently reuses the URLAB_PROTOSPEC=0 makefile and
// fails in Gen/ with 'Cannot open include file' exactly as it did before
// the install existed. Registered unconditionally and by header rather
// than by library: the absent -> present transition is the one that must
// invalidate, and these two headers are precisely what Gen/ cannot find
// when the staging has not been run.
ExternalDependencies.Add(Path.Combine(Root, "sdk", "protospec", "profile.h"));
ExternalDependencies.Add(Path.Combine(Root, "generated", "types.h"));
if (!Directory.Exists(IncludePath) || !Directory.Exists(LibPath))
{
Console.WriteLine(
Expand Down
Loading