Repository navigation
Real-node integration suite: the wallet engine against a spawned rand-node (CI job real-node on fullnode v0.7.1) - #2
Merged
Conversation
…prover.e2e allows the test FRI profile on a release node Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HetkTGUHukuapaUf6gqGyr
…act, flows, spend, transport, restart); makeWallet exposes anchorAndWitnesses Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HetkTGUHukuapaUf6gqGyr
….7.1); document e2e-node Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HetkTGUHukuapaUf6gqGyr
…replay and malformed-submit assertions, order-independent c cases, looser timeouts, core/target cache) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HetkTGUHukuapaUf6gqGyr
…n new reads (exact shapes there, -32601 by name on v0.7.1) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HetkTGUHukuapaUf6gqGyr
dendisuhubdy
force-pushed
the
test/node-integration
branch
from
October 11, 2026 07:44
fc4be54 to
e9345f6
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
… binary needs GLIBC 2.38, which 22.04 (2.35) lacks Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HetkTGUHukuapaUf6gqGyr
dendisuhubdy
marked this pull request as ready for review
October 11, 2026 22:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration tests between the full node and the wallet clients, as asked on 2026-10-11. The suite spawns one
rand-node(faucet, test FRI profile) and runs the realmakeRpc/makeWalletengine with the wasm core against it:web/wallet/test/node.e2e.test.mjs— 18 cases: chain identity vs the genesis the node was cut from; every RPC method the wallet calls validated in its empty and (where the test can produce it) populated shape; keygen → faucet → scan → balance → activity, a second wallet rescanning the same key, idempotent scan, witnesses rooted atrand_getAnchor; a spend through a realrand-proverwith exact balance deltas and the replay refused (-32000 "nullifier already spent"); failover, submits not repeated, the node's JSON-RPC errors passed through intact; a node restart on the same data dir.web/wallet/test/node-harness.mjs— the spawn/until/genesis helpers, shared withprover.e2e.test.mjs(which now setsRAND_ALLOW_TEST_FRI_PROFILE=1, without which a release node refuses the test genesis).scripts/e2e-node.shand.github/workflows/node-integration.yml(jobreal-node: builds the wasm core, downloads the fullnode v0.7.1 release assets, runs the suite). Skips cleanly withoutRAND_NODE_BIN.makeWalletexposesanchorAndWitnesses(already an internal function) so it can be tested.Locally against fullnode main (37c4fdd3): 17 pass, 1 skipped. The skipped case documents a bug:
ui/engine/rpc.jsfiles a connection dropped after the request was read asconnect(line ~288) andmayRetryElsewhere(line ~184) then repeatsrand_mint/rand_sendTransactionon the next endpoint — a double-submit risk. Not fixed here.Pre-existing, not fixed:
prover.e2e's "with no prover running" case expectscanProve()to say no in device mode, but in-wallet proving now answers yes.The companion is fullnode PR "rpc_contract: the wallet's rows".
🤖 Generated with Claude Code
https://claude.ai/code/session_01HetkTGUHukuapaUf6gqGyr