Repository navigation
RDBC-1170 Restore HTTP keep-alive for plain HTTP connections - #610
Merged
Merged
Conversation
undici Agent with pipelining: 0 disables keep-alive, so every request opened a new TCP connection. Use undici defaults (pipelining: 1, keep-alive on), same as the certificate agent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue link
https://issues.hibernatingrhinos.com/issue/RDBC-1170
Description
pipelining: 0disables keep-alive; the agent now uses undici defaultspipelining: 1keeps connections alive, still one request in flight per connectionconnectevents over 20 loads (21 before the fix)Type of change
x.y.z->x.y.z)Target branch and backports
v7.2,v7.1,v7.0,v6.0)How risky is the change?
Backward compatibility
Server compatibility
Affected runtimes
Public API
src/index.ts(npm run check-exportspasses).package.jsonandCLIENT_VERSIONinsrc/Http/RequestExecutor.ts(sync / release PRs only)Documentation update
README.mdhas been updatedTesting by Contributor
npm run lint,npm run build,npm run check-exportsandnpm run check-importspass locallyRAVENDB_TEST_SERVER_PATH/RAVENDB_SERVER_VERSION)Dependencies
Is there any existing behavior change of other features due to this change?