Repository navigation
RavenDB-27689 Write a single include clause for subscription counter and time series includes - #323
Merged
poissoncorp merged 1 commit intoOct 23, 2026
Conversation
…and time series includes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subscriptions with counter includes sent an
includeclause the server rejected.ensure_criterianow writes a single comma-separated clause, as C# does:includeis written when nothing was included yet. The check was inverted, soinclude_counters("Pros", "Cons")sentas doccounters('pros'),counters('cons').,separator is written, sodoc.Company,counters()instead ofdoc.Companycounters(). C# and Node.js miss this separator too.includeclause. Not in the ticket.Tests:
ravendb/tests/issue_tests/test_RavenDB_27689.py, 4 tests against a 7.2.7 RC server, all failing on the previous code.black --checkpassed.Ticket: RavenDB-27689