Repository navigation
VPAAMP-1533 Video freeze in ad-to-ad transition - #2146
Draft
anjali-syna wants to merge 1 commit into
Draft
anjali-syna wants to merge 1 commit into
anjali-syna wants to merge 1 commit into
Conversation
…ithout Mp4Demuxer Reason for change: First ad player pushes the Encrypted header. So, SetTrackEncrypted is properly set from this flow. Second ad player onwards reuses the already pushed header but SetTrackEncrypted is missing, which is required to keep the pipeline encrypted across various ad and content players. Changes: * Call to SetTrackEncrypted is kept out of eAAMPConfig_UseMp4Demux config check Test Procedure: Refer JIRA ticket Risks: low Signed-off-by: anjali-syna <206662904+anjali-syna@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Video freeze in ad-to-ad transition in Non direct Rialto without Mp4Demuxer
Reason for change: First ad player pushes the Encrypted header.
So, SetTrackEncrypted is properly set from this flow.
Second ad player onwards reuses the already pushed header
but SetTrackEncrypted is missing, which is required to keep
the pipeline encrypted across various ad and content players.
Changes:
Test Procedure: Refer JIRA ticket
Risks: low