Repository navigation
chore: auto-sync develop → main (direct push failure) - #146
Merged
7 commits merged intoOct 20, 2026
Merged
7 commits merged into
7 commits merged into
Conversation
Align transport release workflow with client safeguards
RDKEMW-26909 : Align CI workflows with heatmap standard
#145) * RDKEMW-26355: Propagate backend errors from invoke() and remove set()/send() * RDKEMW-26355 : Add 1.1.13 changelog and document connection callback threading
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Public interface removals break binary compatibility, and release promotion can publish content absent from the selected release candidate.
3 open issues
What changed in this PR
Syncs develop into main, bringing transport API changes, updated tests and documentation, and CI/release workflow revisions.
Changes:
- Makes helper invocation wait for backend responses and removes
set()andsend(). - Uses the configured subscription acknowledgement timeout.
- Extracts reusable unit-test CI and revises release validation.
| File | Description |
|---|---|
| test/unit/helperTest.cpp | Tests response-based invocation and error propagation. |
| test/unit/gatewayTest.cpp | Updates request triggers and acknowledgement testing. |
| src/helpers_impl.h | Implements blocking invocation with backend errors. |
| src/gateway.cpp | Removes send handling and adjusts subscription timeout. |
| README.md | Removes the setter example. |
| openspec/specs/transport_recommendations_spec.md | Removes setter references. |
| openspec/specs/transport_layer_spec.md | Updates supported gateway operations. |
| openspec/specs/json_rpc_handling_spec.md | Removes gateway send references. |
| openspec/specs/header_interfaces_spec.md | Removes setter interface references. |
| openspec/specs/cpp_specifics_spec.md | Updates helper coverage references. |
| include/firebolt/helpers.h | Removes setter and documents blocking invocation. |
| include/firebolt/gateway.h | Removes send and revises callback documentation. |
| CHANGELOG.md | Documents 1.1.13 behavior and removals. |
| .github/workflows/tests-trigger.yml | Delegates tests and updates coverage artifacts. |
| .github/workflows/release.yml | Revises release validation and serialization. |
| .github/workflows/L1-tests.yml | Adds reusable tests and coverage workflow. |
| .github/instructions/coding-guidelines.instructions.md | Removes references to deleted APIs and members. |
Review effort: Balanced
| if [ "$IS_PROMOTION" = "true" ]; then | ||
| if [ "$(git rev-parse HEAD)" != "$(git rev-parse "${BASELINE}^{commit}")" ]; then | ||
| echo "ERROR: HEAD has moved past ${BASELINE}. Cut a new RC from the current HEAD before promoting to stable." | ||
| if ! git merge-base --is-ancestor "${BASELINE}" HEAD; then |
| virtual ~IHelper() = default; | ||
|
|
||
| virtual Result<void> set(const std::string& methodName, const nlohmann::json& parameters) = 0; | ||
| // Blocks until the backend replies and returns its error, if any. |
| const std::string methodName = "test.set"; | ||
| const nlohmann::json params = {{"key", "value"}}; | ||
| EXPECT_CALL(mockGateway, request("test.invoke", _)) | ||
| .WillOnce(Return(ByMove(readyFuture(Result<nlohmann::json>{nlohmann::json{nullptr}})))); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic sync of
develop→maincould not complete via direct workflow push.Action required: resolve the conflicts in this PR, then merge it.
Detected reason: direct push failure
Triggered by: 961c832 on develop