Repository navigation
Sync main - #147
Merged
Merged
Sync main#147
Conversation
Align transport release workflow with client safeguards
RDKEMW-26909 : Align CI workflows with heatmap standard
#145) * RDKEMW-26355: Propagate backend errors from invoke() and remove set()/send() * RDKEMW-26355 : Add 1.1.13 changelog and document connection callback threading
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Public interface removals break binary compatibility, and release promotion permits content differing from the selected release candidate.
3 open issues
What changed in this PR
Synchronizes transport API, tests, documentation, and release automation.
Changes:
- Makes
invoke()wait for backend results and removesset()andsend(). - Uses the configured subscription acknowledgement timeout and updates tests.
- Extracts reusable L1 testing and revises release validation.
| File | Description |
|---|---|
| test/unit/helperTest.cpp | Tests response-based invocation and errors. |
| test/unit/gatewayTest.cpp | Replaces sends and tests delayed acknowledgements. |
| src/helpers_impl.h | Implements response-based invocation. |
| src/gateway.cpp | Removes send handling and updates acknowledgement timing. |
| README.md | Removes the setter example. |
| openspec/specs/transport_recommendations_spec.md | Removes setter coverage reference. |
| openspec/specs/transport_layer_spec.md | Removes public send requirements and references. |
| openspec/specs/json_rpc_handling_spec.md | Removes gateway send references. |
| openspec/specs/header_interfaces_spec.md | Removes setter references. |
| openspec/specs/cpp_specifics_spec.md | Removes implementation setter reference. |
| include/firebolt/helpers.h | Removes setter and documents blocking invocation. |
| include/firebolt/gateway.h | Removes send and revises callback documentation. |
| CHANGELOG.md | Documents API changes and releases. |
| .github/workflows/tests-trigger.yml | Delegates L1 tests and updates artifact consumption. |
| .github/workflows/release.yml | Revises release guards and serialization. |
| .github/workflows/L1-tests.yml | Adds reusable testing and coverage workflow. |
| .github/instructions/coding-guidelines.instructions.md | Updates examples for removed APIs and members. |
Review effort: Balanced
brendanobra
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.