Repository navigation
RDKEMW-25174 : Analytics events are not getting posted as expected wi… - #148
Merged
Merged
Conversation
…th Nativescript wgt Reason for change: Updated the Timer polyfills Test Procedure: build should be successful. Risks: low Priority: P2
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Timer wrappers may capture undefined functions, and fetch failure paths leave cleanup incomplete.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This PR updates timer polyfills and improves fetch error/timeout handling for NativeScript widgets.
Changes:
- Reworks timer wrappers and callback invocation.
- Handles invalid response chunks during fetch consumption.
- Adds socket-aware request timeout initialization.
File summaries
| File | Description |
|---|---|
src/jsc/modules/node-fetch.js |
Adds response-body conversion errors and revised request timeout behavior. |
src/jsc/modules/linkedjsdomwrapper.js |
Replaces timer polyfills with wrapped timer implementations. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
vjain008
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…th Nativescript wgt
Reason for change: Updated the Timer polyfills
Test Procedure: build should be successful.
Risks: low
Priority: P2