Skip to content

RDKEMW-24241 : [rdknativescript] Add support for network connections … - #151

Merged
vjain008 merged 1 commit into
developfrom
topic/RDKEMW-24241
Nov 4, 2026
Merged

vjain008 merged 1 commit into
developfrom
topic/RDKEMW-24241

Conversation

@gurpreet319

Copy link
Copy Markdown
Contributor

…in rdknativescript debugger

Reason for change: support for network connection
Test Procedure: build should be successful.
Risks: low
Priority: P2

…in rdknativescript debugger

Reason for change: support for network connection
Test Procedure: build should be successful.
Risks: low
Priority: P2
@gurpreet319
gurpreet319 requested a review from a team as a code owner November 4, 2026 11:28
Copilot AI balanced review requested due to automatic review settings November 4, 2026 11:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

A critical connection-lifetime race can cause use-after-free during WebSocket sends, while additional findings identify broken metric capture and logging, inaccurate HAR timing, and incorrect transfer-size reporting.

7 open issues
What changed in this PR

Adds network-request inspection to the RDK NativeScript debugger, streaming native download metrics to a new Network tab with HAR export.

Changes:

  • Adds live request summaries, bounded capture history, and HAR downloads.
  • Replaces stored native metrics with capture-controlled streaming.
  • Adds shared WebSocket send helpers and connection locking.
File Description
utils/​nativejsinspector.html Adds the Network tab, metric rendering, capture controls, and HAR export.
src/​jsc/​JavaScriptUtils.cpp Updates logging detection and changes the metrics API to toggle capture.
src/​jsc/​JavaScriptContext.cpp Serializes and streams metrics, then releases their memory.
src/​InspectorHTTPServer.cpp Adds network events, shared send logic, and connection locking.
include/​jsc/​JavaScriptContext.h Declares capture state, its mutex, and the capture setter.
include/​InspectorHTTPServer.h Declares network streaming helpers and connection/send mutexes.

Review effort: Balanced

Comment thread src/InspectorHTTPServer.cpp Resolved
Comment thread src/jsc/JavaScriptContext.cpp Resolved
Comment thread src/jsc/JavaScriptUtils.cpp Resolved
Comment thread utils/nativejsinspector.html Resolved
Comment thread utils/nativejsinspector.html Resolved
Comment thread utils/nativejsinspector.html Resolved
Comment thread utils/nativejsinspector.html Resolved
@vjain008
vjain008 merged commit 442ae9c into develop Nov 4, 2026
10 of 11 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants