Repository navigation
RDKEMW-24241 : [rdknativescript] Add support for network connections … - #151
Merged
Merged
Conversation
…in rdknativescript debugger Reason for change: support for network connection Test Procedure: build should be successful. Risks: low Priority: P2
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
A critical connection-lifetime race can cause use-after-free during WebSocket sends, while additional findings identify broken metric capture and logging, inaccurate HAR timing, and incorrect transfer-size reporting.
7 open issues
Dispatch connection lookup and send on the owning main loop · New Preserve environment-controlled network file logging · New Allow capture flag to trigger metric collection · New Avoid using request Content-Length as downloaded size · New Preserve explicitly millisecond-valued HAR fields · New Make HAR phase durations non-overlapping · New Store each request's actual start timestamp · New
What changed in this PR
Adds network-request inspection to the RDK NativeScript debugger, streaming native download metrics to a new Network tab with HAR export.
Changes:
- Adds live request summaries, bounded capture history, and HAR downloads.
- Replaces stored native metrics with capture-controlled streaming.
- Adds shared WebSocket send helpers and connection locking.
| File | Description |
|---|---|
utils/nativejsinspector.html |
Adds the Network tab, metric rendering, capture controls, and HAR export. |
src/jsc/JavaScriptUtils.cpp |
Updates logging detection and changes the metrics API to toggle capture. |
src/jsc/JavaScriptContext.cpp |
Serializes and streams metrics, then releases their memory. |
src/InspectorHTTPServer.cpp |
Adds network events, shared send logic, and connection locking. |
include/jsc/JavaScriptContext.h |
Declares capture state, its mutex, and the capture setter. |
include/InspectorHTTPServer.h |
Declares network streaming helpers and connection/send mutexes. |
Review effort: Balanced
vjain008
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


…in rdknativescript debugger
Reason for change: support for network connection
Test Procedure: build should be successful.
Risks: low
Priority: P2