Extract shared test database setup - #103
Merged
Merged
Conversation
The Test::Unit tests shared one top-level create_and_blow_away_old_db helper defined in test_helper.rb, which mixed connection configuration and schema definition into the global namespace. Move it into a test/support/test_database.rb module that the four test classes using it include. The module exposes the same create_and_blow_away_old_db entry point and keeps the file-backed test.db configuration unchanged, so behavior is identical; it also separates connection setup from schema creation so the connection configuration can be changed in isolation later. The module deliberately defines no setup/teardown instance methods: including classes define their own, so any future lifecycle hook must be registered through Test::Unit's class-level setup/teardown callbacks.
nertzy
marked this pull request as ready for review
September 3, 2026 17:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestDatabasetest-support module.