Repository navigation
ci: skip the PR description check for Dependabot - #304
saadahmed95 wants to merge 1 commit into
Conversation
Dependabot writes its own body with none of the required headings, so every Dependabot pull request showed a red check that nothing could turn green. The author's login decides, so a person editing that body doesn't bring the check back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Lore is reviewing this PR — 0adfcf65-2f24-4aae-8a55-eeac5f535994. Submit a review that requests changes to have Lore push a fix for it. Comment |
|
Nothing blocks this PR from merging now. Lore updates this comment when the reason changes. |
🔍 Lore Spec ImpactExamined 4 changed file(s): 0 had graph data (no coupling found), 3 had none — no ingested test run covers them, so this check cannot speak for them. Also read 1 changed spec/ADR at statement level. 3 new statement(s) have no test link yet. Deterministic · graph @ |
|
@lore review |
|
Lore is reviewing this PR — 3be0d905-7297-40a4-beb7-f680a1e9e2ee. Submit a review that requests changes to have Lore push a fix for it. Comment |
Pull Request
Why
pr-description-check.ymlrequires## Why,## What Changedand## Testing, and Dependabot writes its own body with none of them. Every Dependabot pull request therefore shows a failed check that nothing can turn green, as #302 and #303 do now. The check isn't required, so they can still merge, but the red hides any failure that matters. re-cinq/bowman-ui#400 made the same change for the same reason.What Changed
.github/workflows/pr-description-check.yml: the job is skipped for a pull requestdependabot[bot]opened. It reads the pull request's author rather than the actor, so a person editing a Dependabot body doesn't bring the check back.scripts/pr-description-check.test.ts(new): one test for that condition, and one that runs the step's own script to show it still fails a body lacking the headings, naming each.specs/hal-engine-doc-gates/spec.md: two statements citing those tests, since this repo requires every test to cite one.AGENTS.md: one line under the PR description template.Alternatives Considered
github.actor. That changes with whoever triggered the run, so someone editing the body would bring the failure back.if:reads clearly as skipped in the check list.ADRs & Architecture
None.
Testing
scripts/pr-description-check.test.tspasses, and with theif:removed the first test fails.eslinton the changed files,prettier --check,npm run typecheck,check:spec-links,check:spec-statusanddocs:check-pathspass, andscripts/check-action-pins.mjspasses.bash scripts/check-changelog.sh origin/mainreports no shipped source changed.npm run verify. CI runs it on this pull request.main.Code Quality Checklist
eslintpasses on the changed filesnpm run typecheckpassesprettier --checkpasses on the new testAGENTS.mdand the spec state the rulesrc/Related Issues
None. Follows re-cinq/bowman-ui#400.
🤖 Generated with Claude Code