Skip to content

ci: skip the PR description check for Dependabot - #304

Open
saadahmed95 wants to merge 1 commit into
mainfrom
ci/pr-description-dependabot
Open

saadahmed95 wants to merge 1 commit into
mainfrom
ci/pr-description-dependabot

Conversation

@saadahmed95

Copy link
Copy Markdown
Contributor

Pull Request

Why

pr-description-check.yml requires ## Why, ## What Changed and ## Testing, and Dependabot writes its own body with none of them. Every Dependabot pull request therefore shows a failed check that nothing can turn green, as #302 and #303 do now. The check isn't required, so they can still merge, but the red hides any failure that matters. re-cinq/bowman-ui#400 made the same change for the same reason.

What Changed

  • .github/workflows/pr-description-check.yml: the job is skipped for a pull request dependabot[bot] opened. It reads the pull request's author rather than the actor, so a person editing a Dependabot body doesn't bring the check back.
  • scripts/pr-description-check.test.ts (new): one test for that condition, and one that runs the step's own script to show it still fails a body lacking the headings, naming each.
  • specs/hal-engine-doc-gates/spec.md: two statements citing those tests, since this repo requires every test to cite one.
  • AGENTS.md: one line under the PR description template.

Alternatives Considered

  • Skipping by github.actor. That changes with whoever triggered the run, so someone editing the body would bring the failure back.
  • Skipping inside the step's script. The job would still run for nothing, and a job skipped by if: reads clearly as skipped in the check list.
  • Removing the check. It's still useful on every pull request a person or Lore opens.

ADRs & Architecture

None.

Testing

  • New tests: scripts/pr-description-check.test.ts passes, and with the if: removed the first test fails.
  • Local checks: eslint on the changed files, prettier --check, npm run typecheck, check:spec-links, check:spec-status and docs:check-paths pass, and scripts/check-action-pins.mjs passes.
  • Changelog: bash scripts/check-changelog.sh origin/main reports no shipped source changed.
  • Not run locally: the full npm run verify. CI runs it on this pull request.
  • After merging: the next pull request Dependabot opens should show this job as skipped. build: Bump @types/node from 26.6.5 to 26.6.6 in the production group #302 and build: Bump the development group with 2 updates #303 keep their old result unless they're updated from main.

Code Quality Checklist

  • Lint: eslint passes on the changed files
  • Types: npm run typecheck passes
  • Tests: new tests added and passing
  • No Secrets: No API keys, tokens, or credentials committed
  • Formatting: prettier --check passes on the new test
  • Documentation: AGENTS.md and the spec state the rule
  • Layer Adherence: N/A, outside src/
  • No console.log: none added
  • Changelog: no shipped source changed

Related Issues

None. Follows re-cinq/bowman-ui#400.

🤖 Generated with Claude Code

Dependabot writes its own body with none of the required headings, so every
Dependabot pull request showed a red check that nothing could turn green.
The author's login decides, so a person editing that body doesn't bring the
check back.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@lore-agent

lore-agent Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Lore is reviewing this PR — 0adfcf65-2f24-4aae-8a55-eeac5f535994.

Submit a review that requests changes to have Lore push a fix for it. Comment @lore review to re-run the review.

@lore-agent

lore-agent Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Nothing blocks this PR from merging now. Lore updates this comment when the reason changes.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown

🔍 Lore Spec Impact

Examined 4 changed file(s): 0 had graph data (no coupling found), 3 had none — no ingested test run covers them, so this check cannot speak for them. Also read 1 changed spec/ADR at statement level. 3 new statement(s) have no test link yet.

Deterministic · graph @ db69574 (projected 2026-11-01) · no tests run by this check

@saadahmed95

Copy link
Copy Markdown
Contributor Author

@lore review

@lore-agent

lore-agent Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Lore is reviewing this PR — 3be0d905-7297-40a4-beb7-f680a1e9e2ee.

Submit a review that requests changes to have Lore push a fix for it. Comment @lore review to re-run the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant