Skip to content

A pushed document's signatures are found through the evidence's own document column #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gedaiu merged 1 commit into from
Nov 1, 2026
Merged

A pushed document's signatures are found through the evidence's own document column #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions crates/utopia-store/src/phrase_bindings.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,12 @@ pub async fn signatures<'e>(
}

/// 一篇文档里活着的开放陈述落在哪些签名上（键同 [`PhraseSignature::key`]）。推送来的
/// 文档抽完，本体只判这些签名（#1242）；别的签名还是对齐器的
/// 文档抽完，本体只判这些签名（#1242）；别的签名还是对齐器的。
///
/// 证据按 `fact_evidence.document_id` 找（`fact_evidence_document_idx`），不经 `chunks`：
/// `fact_evidence.chunk_id` 没有索引，经 chunk 找要全表扫一遍证据，830 万行的库上每篇
/// 文档 12 秒，推送一阵时几十份同时跑，把数据库顶在 CPU 上限（#1471）；按文档列走索引
/// 是 0.16 秒，行一样——证据的 document_id 写入时就等于它 chunk 的文档
pub async fn signature_keys_of_document(
pool: &PgPool,
kb_id: Uuid,
Expand All @@ -128,8 +133,8 @@ pub async fn signature_keys_of_document(
LEFT JOIN entities o ON o.id = f.object_id
WHERE f.kb_id = $1 AND f.layer = 'open' AND f.invalidated_at IS NULL
AND f.phrase IS NOT NULL AND btrim(f.phrase) <> ''
AND EXISTS (SELECT 1 FROM fact_evidence fe JOIN chunks c ON c.id = fe.chunk_id
WHERE fe.fact_id = f.id AND c.document_id = $2)",
AND EXISTS (SELECT 1 FROM fact_evidence fe
WHERE fe.fact_id = f.id AND fe.document_id = $2)",
phrase = phrase_sql("f.phrase")
);
Ok(sqlx::query_as(&sql)
Expand Down
Loading