Conversation
a-ctor
changed the title
MichaelKetting
left a comment
MichaelKetting
left a comment
There was a problem hiding this comment.
I got some simplification and a possible re-design of where the code should go. I hven't tried it. Please test.
| /// While the usage get rewritten, it is also necessary to disable re-linqs evaluation as | ||
| /// it tries to constant fold the expression otherwise, which causes runtime exceptions. | ||
| /// </remarks> | ||
| public class ByRefLikeAwareEvaluatableExpressionFilter : EvaluatableExpressionFilterBase |
There was a problem hiding this comment.
Please create a ticket in sqlbackend. I think we should move this logic there eventually.
| /// Transforms <see cref="MemoryExtensions"/>.<see cref="MemoryExtensions.Contains"/> calls generated by the C# 14 compiler back to their | ||
| /// <see cref="Enumerable"/>.<see cref="M:System.Linq.Enumerable.Contains``1(System.Collections.Generic.IEnumerable{``0},``0)"/> equivalent. | ||
| /// </summary> | ||
| public class SpanContainsExpressionTransformer : IExpressionTransformer<MethodCallExpression> |
There was a problem hiding this comment.
this should also go into Remotion.Linq (RMLNQ) eventually. please create a ticket
f0126e4 to
5b1974f
Compare
5c26f89 to
aa00675
Compare
There was a problem hiding this comment.
Ad discussed:
solution with new transformer doe to comaptiblity issues.
no change in re-linq right now.
Please make a ticket in RMLNQ for this.
Please add unit tests for the classes, not just the integration test.
Integration tests: please check that the "all" the classic contains keep working, too. I'm not sure how many tests we have. We should be able to simulate C#-v-old by adding COntains that are not affected by the change.
aa00675 to
5eb6376
Compare
2 participants
No description provided.