Run AnimationBackend commit hook on ReactRevisionMerge commits#57410
Open
bartlomiejbloniarz wants to merge 1 commit into
Open
Run AnimationBackend commit hook on ReactRevisionMerge commits#57410bartlomiejbloniarz wants to merge 1 commit into
bartlomiejbloniarz wants to merge 1 commit into
Conversation
Summary: `AnimationBackendCommitHook` reconciles animated props during React commits to prevent React from overwriting animation-driven prop updates. Commits with source `ReactRevisionMerge` were being excluded, which currently was not a problem, because this source is only used with fabricCommitBranching which is currently disabled. Changelog: [General][Fixed] - Add `ReactRevisionMerge` source to the AnimationBackendCommitHook Differential Revision: D110459778
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@bartlomiejbloniarz has exported this pull request. If you are a Meta employee, you can view the originating Diff in D110459778. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
AnimationBackendCommitHookreconciles animated props during React commits to prevent React from overwriting animation-driven prop updates. Commits with sourceReactRevisionMergewere being excluded, which currently was not a problem, because this source is only used with fabricCommitBranching which is currently disabled.Changelog:
[General][Fixed] - Add
ReactRevisionMergesource to the AnimationBackendCommitHookDifferential Revision: D110459778