Colocate deprecated native component specs with their components#57416
Closed
rubennorte wants to merge 1 commit into
Closed
Colocate deprecated native component specs with their components#57416rubennorte wants to merge 1 commit into
rubennorte wants to merge 1 commit into
Conversation
Summary: Moves the native component specs out of the legacy `specs_DEPRECATED/components` directory and into a `specs/` folder colocated with the component they belong to, under `src/private/components/<component-name>/specs/`. The directory name for each component is its public name, lowercased and without spaces (e.g. `DrawerLayoutAndroid` -> `drawerlayoutandroid`, `RefreshControl` -> `refreshcontrol`). This continues the effort described in the `specs_DEPRECATED` README of gradually moving specs out of that directory until it can be removed. Specs shared by the same public component are grouped together (e.g. `AndroidSwitchNativeComponent` and `SwitchNativeComponent` under `switch/specs`, `AndroidSwipeRefreshLayoutNativeComponent` and `PullToRefreshViewNativeComponent` under `refreshcontrol/specs`). Relative imports inside each moved spec were updated for the new depth, and every consumer (the re-export shims under `Libraries` plus the colocated `scrollview` and `safeareaview` consumers) now points at the new location. Public import paths are unchanged because the `Libraries` re-export shims are preserved. Codegen still discovers the specs since it scans the whole `src` directory. Changelog: [Internal] Differential Revision: D110472967
meta-cla
Bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D110472967. |
|
This pull request has been merged in a7959dd. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Moves the native component specs out of the legacy
specs_DEPRECATED/componentsdirectory and into aspecs/folder colocated with the component they belong to, undersrc/private/components/<component-name>/specs/. The directory name for each component is its public name, lowercased and without spaces (e.g.DrawerLayoutAndroid->drawerlayoutandroid,RefreshControl->refreshcontrol).This continues the effort described in the
specs_DEPRECATEDREADME of gradually moving specs out of that directory until it can be removed. Specs shared by the same public component are grouped together (e.g.AndroidSwitchNativeComponentandSwitchNativeComponentunderswitch/specs,AndroidSwipeRefreshLayoutNativeComponentandPullToRefreshViewNativeComponentunderrefreshcontrol/specs).Relative imports inside each moved spec were updated for the new depth, and every consumer (the re-export shims under
Librariesplus the colocatedscrollviewandsafeareaviewconsumers) now points at the new location. Public import paths are unchanged because theLibrariesre-export shims are preserved. Codegen still discovers the specs since it scans the wholesrcdirectory.Changelog: [Internal]
Differential Revision: D110472967