Skip to content

[iOS] Skip no-op ellipsis recolor in processTruncatedAttributedText #58281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cezarywojcik wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[iOS] Skip no-op ellipsis recolor in processTruncatedAttributedText #58281

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e69a59f
Skip no-op ellipsis recolor in processTruncatedAttributedText
cezarywojcik Sep 2, 2026
79dbf7b
Keep original comment
cezarywojcik Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion ...r/textlayoutmanager/platform/ios/react/renderer/textlayoutmanager/RCTTextLayoutManager.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,10 +347,25 @@ - (void)processTruncatedAttributedText:(NSTextStorage *)textStorage
// Remove color attributes for truncated range
for (NSAttributedStringKey key in
@[ NSForegroundColorAttributeName, NSBackgroundColorAttributeName ]) {
[textStorage removeAttribute:key range:characterRange];
id attribute = [textStorage attribute:key
atIndex:characterRange.location - 1
effectiveRange:nil];
__block BOOL rangeAlreadyMatches = YES;
[textStorage enumerateAttribute:key
inRange:characterRange
options:0
usingBlock:^(id value, NSRange range, BOOL *stopEnumerating) {
BOOL isEqual = value == attribute ||
(value != nil && attribute != nil && [value isEqual:attribute]);
if (!isEqual) {
rangeAlreadyMatches = NO;
*stopEnumerating = YES;
}
}];
if (rangeAlreadyMatches) {
continue;
}
[textStorage removeAttribute:key range:characterRange];
if (attribute != nullptr) {
[textStorage addAttribute:key value:attribute range:characterRange];
}
Expand Down