Introduce PCH for codegen targets - #58317
Open
lukmccall wants to merge 1 commit into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Upstream precompiled headers configuration on Android that was added to Expo in SDK 56.
Related Expo PRs:
In an Expo test app with ~17 turbomodules, I was able to reduce the C++ build time from ~16 min to ~5 min.
These changes only affect the codegen targets. They shouldn't affect user code.
Changelog:
[ANDROID] [ADDED] - Introduce PCH for codegen targets to improve compilation time
Test Plan:
assembleDebugandassembleReleaseinrn-tester✅rn-testerin Android Studio to check if the sync workaround works ✅Similar changes were added to Expo some time ago and have worked well in production.