fix(image): preserve source headers with crossOrigin and referrerPolicy - #58319
Closed
mfkrause wants to merge 2 commits into
Closed
fix(image): preserve source headers with crossOrigin and referrerPolicy#58319mfkrause wants to merge 2 commits into
mfkrause wants to merge 2 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
javache
requested changes
Sep 4, 2026
javache
approved these changes
Sep 4, 2026
|
@javache has imported this pull request. If you are a Meta employee, you can view this in D118797893. |
Contributor
Any reason you went with this? Wouldn't the headers in the URI be more specific? |
Contributor
Author
|
@javache To preserve existing behavior for conflicting names. The current implementation replaces I agree that the better / more correct design would be to have user-supplied source headers take precedence, however. Happy to reverse that order if you'd prefer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When
crossOrigin="use-credentials"orreferrerPolicyis used on anImage,getImageSourcesFromImagePropscurrently fully replacessource.headers, removing custom headers such asAuthorization.This fix merges the generated headers with the user-provided source headers instead (generated headers take precedence).
Changelog:
[GENERAL] [FIXED] - Preserve Image source headers when using crossOrigin or referrerPolicy
Test Plan:
Confirmed existing tests are unchanged & added a regression test