Repository navigation
docs: Have the setup prompt read the setup skill by path - #4490
Conversation
The setup skill only runs when a user invokes it, so an agent told to "follow it" calls its Skill tool, which refuses the skill. The prompt now says to read .agents/skills/data-client-setup/SKILL.md, where `npx skills add` puts it for every agent, as llms.txt already does. Also quote the five skill descriptions that `npx skills add` skipped as invalid YAML (an unquoted `: `), with a test that keeps them quoted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y5C5ZA4ZzZpLn9DzCYbFei
…ore unquoted frontmatter Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y5C5ZA4ZzZpLn9DzCYbFei
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Docs preview: https://docs-site-pr-4490-data-client.vercel.app Built from ebf3293 merged into |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4490 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 161 161
Lines 3080 3080
Branches 605 605
=======================================
Hits 3030 3030
Misses 10 10
Partials 40 40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y5C5ZA4ZzZpLn9DzCYbFei
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y5C5ZA4ZzZpLn9DzCYbFei
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Requested by Nathaniel · project thread
Motivation
Bug fix. A prompt that tells Claude Code to "follow" an installed setup skill can make the agent call its Skill tool. The setup skills are user-invoked only (
disable-model-invocation), so the Skill tool refuses and says not to do the steps another way. In #4464's evals, 2 of 6 runs stopped there with "The REST setup skill (data-client-rest-setup) is already installed; follow it." The site's setup prompt ends the same way ("then follow it").While checking where
npx skills addputs files, it also skipped five skills (data-client-react,-vue,-manager,-react-testing,-vue-testing) with a YAML parse warning: their descriptions are unquoted and contain:. Sonpx skills add reactive/data-clientinstalled 10 of 15 skills.Solution
The prompt now tells the agent to read the file, the way llms.txt, the router skill and the axios guide already do:
Before:
Install its setup skill first: `npx skills add reactive/data-client --skill data-client-setup -y`, then follow it.After:
Install its setup skill first: `npx skills add reactive/data-client --skill data-client-setup -y`, then read `.agents/skills/data-client-setup/SKILL.md` and follow it.The path is one constant,
setupSkillFileinskillCommands.mjs; llms.txt and AgentPrompt fill it in (AgentPrompt as a{skillFile}placeholder, so translators never touch it). Translations update in the weekly run.The five descriptions are now quoted. A dependency-free test fails on any skill frontmatter value that strict YAML can't read unquoted.
Assumptions and validation
npx skills add ... --skill data-client-setup -ywrites.agents/skills/data-client-setup/SKILL.mdas Claude Code, Cursor, Codex, Gemini CLI, with no agent detected, and with-a '*' --copy; Claude Code also gets a.claude/skillslink. High..claude/skills5+5, setup skill already installed 6+6) and Sonnet (fresh app 3+3). Every run readSKILL.md, installed@data-client/react, addedDataProviderand built; none called the Skill tool. So the old wording didn't reproduce feat: Make the axios migration work end to end #4464's refusal here; the new wording removes the opening for it. Medium: n is small.npx skills addfor the React skills (published packages don't shipdata-client-skillsyet), and 36 of 38 hit the YAML skip fordata-client-react,-react-testingand-manager.npx skills add <this branch> --skill '*' -yinstalls all 15 skills with no warnings. High.node --test '.claude-plugin/*.test.mjs'passes; the new test fails on master's five files. High.🤖 Generated with Claude Code
https://claude.ai/code/session_01Y5C5ZA4ZzZpLn9DzCYbFei