Skip to content

docs: Keep DiffEditor's loading diff from spilling over the content below #4491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntucker merged 2 commits into from
Oct 27, 2026
Merged

docs: Keep DiffEditor's loading diff from spilling over the content below #4491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a32752c
docs: Keep DiffEditor's loading diff from spilling over the content b…
claude Oct 27, 2026
d94c990
docs: Don't tie the DiffEditor loading rule to Monaco's wrapper depth
claude Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion website/src/components/DiffEditorMonaco.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,10 @@ export default function DiffEditor({ sides, fallback }: DiffMonacoProps) {
onMount={handleDiffMount}
height={height}
theme={MONACO_THEME}
loading={fallback}
// diffLoading lets the loading box take the static diff's height
loading={
<div className={styles.diffLoading}>{fallback}</div>
}
// Prevent "TextModel got disposed before DiffEditorWidget model got reset" error
// by not letting @monaco-editor/react manage model disposal
keepCurrentOriginalModel
Expand Down
5 changes: 5 additions & 0 deletions website/src/components/Playground/styles.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1457,6 +1457,11 @@ div.fixtureJson + div.fixtureJson {
.playgroundEditor > section {
position: auto !important;
}
/* The section's inline height is Monaco's estimate; the static diff shown
while it loads wraps and has title bars, so let it keep its own height */
.playgroundEditor > section:has(.diffLoading) {
height: auto !important;
}

/* Side by side when the playground itself has enough width (docs sidebar
no longer forces an incorrect stack on homepage/blog): a grid, the file
Expand Down
Loading