Repository navigation
docs: End the Live Preview's sheet at its content - #4494
Conversation
The app's sheet in row playgrounds ran up to 6rem past its content toward the code card's foot, leaving empty space under short demos (todo list, optimistic votes). Its foot is now just its corners; the code card still stretches toward a taller preview. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y5C5ZEFG3T2KLkFQtTieT5
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Docs preview: https://docs-site-pr-4494-data-client.vercel.app Built from 01d16fd merged into |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4494 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 161 161
Lines 3080 3080
Branches 605 605
=======================================
Hits 3030 3030
Misses 10 10
Partials 40 40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Requested by Nathaniel · project thread
Motivation
Improvement. In row playgrounds, when the code card is taller than the demo, the Live Preview's sheet runs on up to 6rem past its content toward the code card's foot. Short demos show a block of empty panel under the app: about 106px under the todo list on the mutations page, and 110px under "Optimistic mutations based on previous state" at 1920px wide.
Solution
The app's sheet foot (
.row > .previewWrapper::after) is now only its rounded corners (--pg-card-radius), so the sheet ends at its content plus its normal padding. The code card still stretches toward a taller preview by up to 6rem, as before. The loading-page gap calculation uses the same foot height so the folder doesn't jump on hydration.Assumptions and validation
Generated by Claude Code
Note
Low Risk
Scoped CSS layout tweaks for docs playground chrome only; no runtime logic, APIs, or data handling.
Overview
Row playgrounds no longer paint a tall empty band under short Live Preview demos when the code editor is taller than the app.
The preview wrapper’s sheet foot (
.row > .previewWrapper::after) now caps at--pg-card-radius(rounded corners only) instead of sharing the code card’s up-to-6rem stretch toward the other column. The editor side still uses--pg-card-footso a tall preview can pull the code card down slightly without the reverse.The loading skeleton
--pg-preview-gapmath uses the same smaller foot height (--pg-card-radiusinstead of--pg-card-foot) so the preview folder doesn’t jump when hydration finishes. Comments instyles.module.csswere updated to match.Reviewed by Cursor Bugbot for commit 01d16fd. Bugbot is set up for automated code reviews on this repo. Configure here.