Repository navigation
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ad8471fbd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pub fn save_active(&mut self, _: &mut Window, _: &mut Context<Self>) {} | ||
| pub fn save_active_as(&mut self, _: &mut Window, _: &mut Context<Self>) {} |
There was a problem hiding this comment.
In the WASM build, selecting either File → Save or File → Save As after editing invokes these empty methods even though both menu entries are enabled in top_bar.rs. The operation produces no download, persistence, or error, so users can reasonably believe their document was saved and then lose all edits on close or reload; implement browser package export/download or disable these commands with a clear explanation.
Useful? React with 👍 / 👎.
|
|
||
| pub fn close_document_panel(&mut self, panel_id: Uuid, window: &mut Window, cx: &mut Context<Self>) { | ||
| self.remove_document_panel(panel_id, window, cx); |
There was a problem hiding this comment.
When a browser document has unsaved edits, clicking the tab close button or File → Close File immediately removes the panel through this method without checking editor dirtiness or asking for confirmation. Because browser documents currently live only in memory, an accidental close irreversibly discards the work; retain the native close-confirmation behavior or add an equivalent WASM prompt before removal.
Useful? React with 👍 / 👎.
Summary
Validation
Notes