Keep generic static union docblock in RemoveDuplicatedReturnSelfDocblockRector#8150
Merged
Merged
Conversation
samsonasik
approved these changes
Jul 6, 2026
Member
|
LGTM 👍 Thanks |
Contributor
Author
|
@TomasVotruba thank you for the quick merge. Is it already possible to ship a new version for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RemoveDuplicatedReturnSelfDocblockRectorincorrectly strips@return static<string|int>docblocks when the native return type is self. The rule already preservedGenericObjectTypeannotations (e.g.self<TValue, never>) but did not account forGenericStaticType.This adds a
GenericStaticTypecheck so that generic@return static<...>narrowing annotations are kept, and adds a fixture to cover the case.