feat(#4285): wire ConnectorConfigReader runtimeEnabled to RuntimeConfigResolver by fullsend-ai-coder[bot] · Pull Request #4316 · redhat-developer/rhdh-plugins

fullsend-ai-coder · 2026-08-14T12:15:53Z

Inject RuntimeConfigResolver into ConnectorConfigReader so that the runtimeEnabled flag for each connector is resolved via the two-layer config model (YAML baseline + DB overrides) instead of YAML-only via ConfigApi. This enables admin panel toggles for connector runtime sync to take effect within the 30-second cache TTL.

Changes:

ConnectorConfigReader: add resolver option, make
listCandidates() async, replace getRuntimeEnabled() with
resolveRuntimeEnabled() that calls resolver.resolve() for
registered BoostConfigKey fields with YAML-only fallback
HealthStatusService: await the now-async listCandidates()
plugin.ts: pass runtimeConfigResolver to ConnectorConfigReader
Tests: update mocks for async listCandidates, add test cases
for YAML-only default, DB override, startup-disabled exclusion,
and resolver key verification
API reports: regenerated for public API surface change

Closes #4285

Post-script verification

Branch is not main/master (agent/4285-wire-runtime-enabled)
Secret scan passed (gitleaks — e6c850f7dd03d646d614fb0c74f80e7e4b9d0026..HEAD)
Pre-commit hooks passed (authoritative run on runner)
Tests ran inside sandbox

rhdh-gh-app · 2026-08-14T12:16:20Z

Important

This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior.

Changed Packages

Package Name	Package Path	Changeset Bump	Current Version
@red-hat-developer-hub/backstage-plugin-boost-backend	workspaces/boost/plugins/boost-backend	minor	`v0.4.0`

codecov · 2026-08-14T12:17:15Z

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

mareklibra · 2026-08-17T06:50:01Z

/fs-fix changeset and all known issues so far (like CI)

fullsend-ai-coder · 2026-08-17T06:51:45Z

🤖 Finished Fix · ✅ Success · Started 6:51 AM UTC · Completed 7:12 AM UTC

Commit: 5b43cb9 · View workflow run →

fullsend-ai-coder · 2026-08-17T07:11:54Z

🔧 Fix agent — iteration 1 (human-triggered)

Added missing changeset for boost-backend (minor) and fixed CI api-report failure by reverting the frontend report.api.md to main's version since this PR does not modify frontend code.

Fixed (2):

missing changeset for boost-backend: Added changeset wire-runtime-config-resolver.md covering @red-hat-developer-hub/backstage-plugin-boost-backend as minor: ConnectorConfigReader now resolves runtimeEnabled via RuntimeConfigResolver, listCandidates() is async, and ConnectorConfigReaderOptions requires a resolver.
CI api-report check failure on merge commit: Reverted frontend boost/report.api.md to origin/main version. This PR does not change frontend code, but the PR commit included stale reorderings from regenerating api-reports against the branch's codebase. When CI merges with main (which has feat: pivot boost plugins to new entity kinds (AiResource/agent, AiModelServerAPI) #4259 pivot changes), the generated frontend report didn't match the committed version, causing the 'check api reports and generate API reference' step to fail for both node 22 and node 24.

Tests: passed

_{Updated by fullsend fix agent}

- Add changeset for boost-backend minor: ConnectorConfigReader now resolves runtimeEnabled via RuntimeConfigResolver (async listCandidates, required resolver option) - Revert frontend boost/report.api.md to main's version since this PR does not change frontend code; the stale reorderings caused CI api-report check failures on the merge commit Addresses review feedback on #4316

mareklibra · 2026-08-17T07:32:13Z

/fs-review

fullsend-ai-review · 2026-08-17T07:33:16Z

🤖 Finished Review · ✅ Success · Started 7:33 AM UTC · Completed 8:06 AM UTC

Commit: 15b6e9c · View workflow run →

fullsend-ai-review · 2026-08-17T08:06:33Z

Looks good to me

Previous run

Review

Findings

Medium

[breaking-change-return-type] workspaces/boost/plugins/boost-backend/report.api.md:340 — ConnectorConfigReader.listCandidates() return type changed from ConnectorCandidate[] to Promise<ConnectorCandidate[]>. This is a breaking change to the @public API surface. Any downstream consumer calling listCandidates() synchronously will receive a Promise object instead of an array. The changeset explicitly documents this as BREAKING, and the only in-repo caller (HealthStatusService.getHealthStatuses) is already async and updated with await.
Remediation: Verify that no other repositories import and call ConnectorConfigReader.listCandidates() synchronously. The changeset already documents the migration path.
[breaking-change-constructor-options] workspaces/boost/plugins/boost-backend/report.api.md:344 — ConnectorConfigReaderOptions now requires a new mandatory field resolver: RuntimeConfigResolver. Any code constructing a ConnectorConfigReader outside of plugin.ts must now supply a RuntimeConfigResolver instance. The changeset documents this as BREAKING.
Remediation: Ensure the BREAKING label and migration instructions in the changeset are sufficient for any external consumers.

Low

[out-of-scope-boundary] workspaces/boost/plugins/boost-backend/src/ingestion/ConnectorConfigReader.ts:270 — The resolveRuntimeEnabled() method checks if (key in boostConfigFields) before using the resolver, falling back to YAML-only for unregistered keys. No test verifies this fallback path. However, the path is currently unreachable in practice because all three KNOWN_CONNECTOR_TYPES (github, gitlab, jira) have corresponding boostConfigFields entries.
[error-handling-idiom] workspaces/boost/plugins/boost-backend/src/ingestion/ConnectorConfigReader.ts:98 — The catch block logs ${error} via template literal, which may lose context for non-Error values or Error cause chains. This is consistent with the existing pattern in this file.

Labels: PR modifies boost workspace ingestion and config resolution code; changeset declares a feature-level change

Previous run (2)

Review

Findings

Medium

[breaking-api-change-semver-mismatch] workspaces/boost/plugins/boost-backend/report.api.md:340 — ConnectorConfigReader.listCandidates() return type changes from ConnectorCandidate[] to Promise<ConnectorCandidate[]>, and ConnectorConfigReaderOptions gains a new required field resolver: RuntimeConfigResolver. Both are source-level breaking changes to the @public API surface. The practical risk is mitigated: no other package in the monorepo imports ConnectorConfigReader, and the package is at version 0.x where semver permits breaking changes in minor bumps. Consider noting the breaking change in the changeset description for better developer communication.

Low

[edge-case] workspaces/boost/plugins/boost-backend/src/ingestion/ConnectorConfigReader.ts:282 — resolveRuntimeEnabled treats any non-boolean resolved value (e.g., string "false" or number 0) the same as undefined, defaulting to true. While boostConfigFields uses z.ZodOptional<z.ZodBoolean>, RuntimeConfigResolver.resolve() returns unknown. A corrupted DB row could cause a connector to silently default to enabled. Consider logging a warning when value !== undefined && typeof value !== 'boolean'.
[unrelated-changes-in-pr] workspaces/boost/plugins/boost/report.api.md:485 — The frontend plugin's report.api.md adds four new translation keys (modelsAvailableTitle, instructionsTitle, handoffDescriptionTitle, ragEnabledLabel) that appear unrelated to the PR's stated scope of wiring ConnectorConfigReader to RuntimeConfigResolver.

mareklibra · 2026-08-17T09:27:54Z

I have sent fixes based on my review.

mareklibra · 2026-08-17T09:55:05Z

/fs-review

fullsend-ai-review · 2026-08-17T09:56:14Z

🤖 Finished Review · ✅ Success · Started 9:56 AM UTC · Completed 10:11 AM UTC

Commit: 147c2ba · View workflow run →

…igResolver Inject RuntimeConfigResolver into ConnectorConfigReader so that the runtimeEnabled flag for each connector is resolved via the two-layer config model (YAML baseline + DB overrides) instead of YAML-only via ConfigApi. This enables admin panel toggles for connector runtime sync to take effect within the 30-second cache TTL. Changes: - ConnectorConfigReader: add resolver option, make listCandidates() async, replace getRuntimeEnabled() with resolveRuntimeEnabled() that calls resolver.resolve() for registered BoostConfigKey fields with YAML-only fallback - HealthStatusService: await the now-async listCandidates() - plugin.ts: pass runtimeConfigResolver to ConnectorConfigReader - Tests: update mocks for async listCandidates, add test cases for YAML-only default, DB override, startup-disabled exclusion, and resolver key verification - API reports: regenerated for public API surface change Closes #4285

- Add changeset for boost-backend minor: ConnectorConfigReader now resolves runtimeEnabled via RuntimeConfigResolver (async listCandidates, required resolver option) - Revert frontend boost/report.api.md to main's version since this PR does not change frontend code; the stale reorderings caused CI api-report check failures on the merge commit Addresses review feedback on #4316

Warn on non-boolean RuntimeConfigResolver values, clarify unit tests, cover resolver-failure YAML fallback, and mark the changeset as BREAKING. Signed-off-by: Marek Libra <marek.libra@gmail.com>

Document RuntimeConfigResolver on ConnectorCandidate, fall back to YAML on unexpected resolver types, and clarify the BREAKING changeset migration. Signed-off-by: Marek Libra <marek.libra@gmail.com>

mareklibra · 2026-08-17T12:01:19Z

/fs-review

fullsend-ai-review · 2026-08-17T12:02:34Z

🤖 Review · ❌ Terminated · Started 12:02 PM UTC · Ended 12:13 PM UTC

Commit: 91b11d6 · View workflow run →

fullsend-ai-review · 2026-08-17T12:13:52Z

🤖 Finished Review · ✅ Success · Started 12:02 PM UTC · Completed 12:13 PM UTC

Commit: 91b11d6 · View workflow run →

sonarqubecloud · 2026-08-17T13:42:15Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

fullsend-ai-coder Bot added the ready-for-review Agent PR ready for human review label Aug 14, 2026

fullsend-ai-coder Bot requested review from a team, durandom, gabemontero, johnmcollier, jordigilh, mareklibra and rohitkrai03 as code owners August 14, 2026 12:15

This comment was marked as outdated.

Sign in to view

fullsend-ai-review Bot added the requires-manual-review Review requires human judgment label Aug 17, 2026

fullsend-ai-review Bot added workspace/boost Boost workspace (Backstage AI plugin) feature labels Aug 17, 2026

fullsend-ai-coder Bot and others added 3 commits August 17, 2026 13:58

fix(#4285): address review findings for runtimeEnabled wiring

5cdefe6

Warn on non-boolean RuntimeConfigResolver values, clarify unit tests, cover resolver-failure YAML fallback, and mark the changeset as BREAKING. Signed-off-by: Marek Libra <marek.libra@gmail.com>

mareklibra force-pushed the agent/4285-wire-runtime-enabled branch from 147c2ba to 5725b69 Compare August 17, 2026 11:59

fix(#4285): address remaining review suggestions for runtimeEnabled

91b11d6

Document RuntimeConfigResolver on ConnectorCandidate, fall back to YAML on unexpected resolver types, and clarify the BREAKING changeset migration. Signed-off-by: Marek Libra <marek.libra@gmail.com>

mareklibra force-pushed the agent/4285-wire-runtime-enabled branch from 5725b69 to 91b11d6 Compare August 17, 2026 12:01

fullsend-ai-review Bot approved these changes Aug 17, 2026

View reviewed changes

fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge and removed requires-manual-review Review requires human judgment labels Aug 17, 2026

mareklibra approved these changes Aug 17, 2026

View reviewed changes

mareklibra enabled auto-merge (squash) August 17, 2026 13:36

Merge branch 'main' into agent/4285-wire-runtime-enabled

330352e

Uh oh!

Conversation

fullsend-ai-coder Bot commented Aug 14, 2026

Post-script verification

Uh oh!

rhdh-gh-app Bot commented Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changed Packages

Uh oh!

codecov Bot commented Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ JUnit XML file not found

Uh oh!

mareklibra commented Aug 17, 2026

Uh oh!

fullsend-ai-coder Bot commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fullsend-ai-coder Bot commented Aug 17, 2026

🔧 Fix agent — iteration 1 (human-triggered)

Uh oh!

mareklibra commented Aug 17, 2026

Uh oh!

fullsend-ai-review Bot commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fullsend-ai-review Bot commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review

Findings

Medium

Low

Review

Findings

Medium

Low

Uh oh!

This comment was marked as outdated.

Uh oh!

mareklibra commented Aug 17, 2026

Uh oh!

mareklibra commented Aug 17, 2026

Uh oh!

fullsend-ai-review Bot commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mareklibra commented Aug 17, 2026

Uh oh!

fullsend-ai-review Bot commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fullsend-ai-review Bot commented Aug 17, 2026

Uh oh!

sonarqubecloud Bot commented Aug 17, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

rhdh-gh-app Bot commented Aug 14, 2026 •

edited

Loading

codecov Bot commented Aug 14, 2026 •

edited

Loading

fullsend-ai-coder Bot commented Aug 17, 2026 •

edited

Loading

fullsend-ai-review Bot commented Aug 17, 2026 •

edited

Loading

fullsend-ai-review Bot commented Aug 17, 2026 •

edited

Loading

fullsend-ai-review Bot commented Aug 17, 2026 •

edited

Loading

fullsend-ai-review Bot commented Aug 17, 2026 •

edited

Loading